After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 648458 - Banshee doesn't import .pls playlist files
Banshee doesn't import .pls playlist files
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Importing
2.0.0
Other Linux
: Normal normal
: 2.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-22 11:04 UTC by michael de
Modified: 2011-05-01 16:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
debug log (8.72 KB, text/plain)
2011-04-24 09:36 UTC, michael de
  Details
sample playlist (3.25 KB, application/octet-stream)
2011-04-26 23:20 UTC, michael de
  Details
should allow importing the playlist (1.15 KB, patch)
2011-04-27 01:22 UTC, Michael Martin-Smucker
committed Details | Review

Description michael de 2011-04-22 11:04:17 UTC
I could not import any .pls format playlist files. They imported just fine in Rhythmbox 0.13.3.

Distribution: Ubuntu 11.04 Beta 2.
Comment 1 Rafael Gomes 2011-04-23 15:29:49 UTC
Thanks for taking the time to report this bug.
This bug report isn't very useful because it doesn't describe the bug well. If you have time and can still reproduce the bug, please read https://bugzilla.gnome.org/bug-HOWTO.html and add a more useful description to this bug.
Comment 2 Michael Martin-Smucker 2011-04-23 16:33:39 UTC
Why was this moved to Rhythmbox?  If I understand the report correctly, things work fine in Rhythmbox, it's importing .pls in Banshee that causes problems.  I'm moving this back to Banshee (sorry if I'm misunderstanding something), however it would still be helpful if you could provide a log, Michael.  Please see http://live.gnome.org/Banshee/CommonQuestions/Logs
Comment 3 michael de 2011-04-24 09:36:07 UTC
Created attachment 186547 [details]
debug log
Comment 4 michael de 2011-04-24 09:40:14 UTC
This is certainly a Banshee bug. I tried importing two different playlists and nothing appeared to happen.
Comment 5 Michael Martin-Smucker 2011-04-26 15:00:25 UTC
Thanks for the log -- I don't see anything unusual in there.  I exported a playlist from Banshee as .pls, deleted the playlist in Banshee, and re-imported it without problems.  What program did you use to create the .pls files?  Also, it might be helpful if you could attach one of .pls playlists that Banshee won't let you import.  Thanks!
Comment 6 michael de 2011-04-26 23:19:34 UTC
I used an Amarok 2.x beta build, maybe some subversion of 2.4. I've attached a .pls. I don't see anything funny except perhaps spaces in the absolute file paths of the playlist entries.
Comment 7 michael de 2011-04-26 23:20:44 UTC
Created attachment 186695 [details]
sample playlist
Comment 8 Michael Martin-Smucker 2011-04-27 01:22:29 UTC
Created attachment 186700 [details] [review]
should allow importing the playlist

It looks like the pls playlist exported by Amarok can't be imported into Banshee because the first line is '[Playlist]' and Banshee is expecting the lowercase '[playlist]'.  This patch fixes the issue for me.
Comment 9 David Nielsen 2011-04-27 01:45:00 UTC
Applies cleanly, and compiles on git master. I can confirm it fixes the issue.

I created a playlist, exported it and removed it. Then I manually capitalized the P to match Amarok's style and reimported the playlist successfully.
Comment 10 michael de 2011-04-27 07:53:47 UTC
Fantastic.
Comment 11 Bertrand Lorentz 2011-05-01 16:35:42 UTC
Review of attachment 186700 [details] [review]:

Committed int git master and the stable-2.0 branch, thanks !

Small nitpick for the next patches : make sure the lines in the commit message don't exceed 72 characters.
Comment 12 Bertrand Lorentz 2011-05-01 16:36:04 UTC
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.