After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 647848 - Failure to compile with GCC 4.6.x due to variable unused but set warnings being treated as errors
Failure to compile with GCC 4.6.x due to variable unused but set warnings bei...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.29
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-15 09:22 UTC by Robert Swain
Modified: 2011-04-16 12:42 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Robert Swain 2011-04-15 09:22:54 UTC
Various elements in -good fail to compile with GCC 4.6.x due to variable unused but set warnings being treated as errors. I will attach a bunch of patches pertaining to this module and this issue here.
Comment 1 Robert Swain 2011-04-15 16:29:55 UTC
http://git.collabora.co.uk/gitweb/?p=user/robswain/gst-plugins-good;a=summary

I dumped the patches here as they were too numerous. Tim did some review on IRC but I didn't manage to address all issues. Still, I hope this goes some way toward cleaning this stuff up in -good even if I'm not the one that finds time to finish it.
Comment 2 Tim-Philipp Müller 2011-04-16 12:42:20 UTC
commit a068133ee767fb4e08bd93e4a0475ec96bd0f266
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Sat Apr 16 13:33:45 2011 +0100

    jack: fix unused-but-set-variable warnings with gcc-4.6

commit 9b93ae0eae16e15ee4324130d42367316d686572
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Sat Apr 16 13:23:50 2011 +0100

    examples: fix 'control reaches end of non-void function' warning in cairo example

commit e02b7e7fdf5160daa6223fd9d0bf463b9ae9abf2
Author: Robert Swain <robert.swain@collabora.co.uk>
Date:   Fri Apr 15 15:47:24 2011 +0200

    v4l2src: Address unused but set variable
    
    The v4l2object formats list was being obtained into a local variable and
    then still used from the context. Make use of the local variable.

commit 75886ba63d13ee590f24b1c779889aea2259ad44
Author: Robert Swain <robert.swain@collabora.co.uk>
Date:   Fri Apr 15 15:17:34 2011 +0200

    oss4: Address unused but set variables
    
    GCC 4.6.x complains about such variable usage. Unused but set variables
    were removed except that gst_oss4_mixer_slider_set_mute () now returns
    the value from the call to gst_oss4_mixer_set_control_val ().

commit 098cf89e340a299d20fcc1d3290835375d1132af
Author: Robert Swain <robert.swain@collabora.co.uk>
Date:   Fri Apr 15 15:14:13 2011 +0200

    jpegenc: pulsesink: raw1394: Address unused but set variables
    
    GCC 4.6.x spits warnings about such usage of variables. The variables in
    raw1394 were marked with G_GNUC_UNUSED as this seemed omre appropriate.
    The others were removed.

commit b5c8c7708bcd92b3b4b558607527dee9380ada07
Author: Robert Swain <robert.swain@collabora.co.uk>
Date:   Fri Apr 15 15:12:44 2011 +0200

    y4mencode: shapewipe: Address unused but set variables
    
    GCC 4.6.x complains about such usage.

commit 4893678fd157fcbb778547808b7bdb9ee0b1b661
Author: Robert Swain <robert.swain@collabora.co.uk>
Date:   Fri Apr 15 15:11:35 2011 +0200

    tests: Address unused but set variables
    
    GCC 4.6.x spits warnings about such usage of variables.


commit e757793b21e4c4e468d829054513bf6866bcc680
Author: Robert Swain <robert.swain@collabora.co.uk>
Date:   Fri Apr 15 15:36:41 2011 +0200

    videomixer: Fix argb/rgba overlay orc code
    
    Remove some redundant operations (convubw) and use the correct variable,
    t2, in the orc_overlay_bgra function.

commit fd6ac6aa8a55fae73f263dbb5bfba8dc2c5d1522
Author: Robert Swain <robert.swain@collabora.co.uk>
Date:   Fri Apr 15 15:33:35 2011 +0200

    videomixer: address unused but set variables
    
    GCC 4.6.x spits warnings about variables that are set but unused. Such
    variables have been removed in blend, collectpads2 and videomixer2.

commit 5b18c652fbb683e0b15a8f7a662e0acb1c32bac4
Author: Robert Swain <robert.swain@collabora.co.uk>
Date:   Fri Apr 15 14:57:20 2011 +0200

    rtp, rtpmanager: Address unused but set variables
    
    GCC 4.6.x spits warnings about variables that are unused but set. Such
    variables have been removed where trivial but with comments left behind
    for informational purposes in some cases.
    
    gst_rtp_session_chain_recv_rtcp () was changed in commit 490113d4
    to always return GST_FLOW_OK instead of the return value of
    rtp_session_process_rtcp (), so we'll keep it that way.

commit 1c6e8682ec12d77d14ac050c32db4cd9c9a97f3b
Author: Robert Swain <robert.swain@collabora.co.uk>
Date:   Fri Apr 15 11:29:30 2011 +0200

    quicktime: Remove unused but set variables
    
    GCC 4.6.x spits warnings about such variable usage. Note that some
    calculations are left as comments for informative purposes.

commit d596c2e9267af5864ad6c4a48ef32654f8566aee
Author: Robert Swain <robert.swain@collabora.co.uk>
Date:   Fri Apr 15 11:23:38 2011 +0200

    matroska: Remove unused but set variables
    
    GCC 4.6.x spits warnings about such variable usage.

commit 101087a23a49cf94ce1fceb814a4a3085e74823a
Author: Robert Swain <robert.swain@collabora.co.uk>
Date:   Fri Apr 15 11:19:26 2011 +0200

    imagefreeze: Remove unused but set duration variable
    
    GCC 4.6.x spits warnings about such variable usage.


commit 383e99c224d262e54dea1d41a8aaf1a0e3986784
Author: Robert Swain <robert.swain@collabora.co.uk>
Date:   Fri Apr 15 11:18:19 2011 +0200

    flxdemux: Remove unused but set keyframe variables
    
    The FIXMEs about the keyframe flag never being used are left for later
    fixing, at which point the keyframe variables could be added back.

commit 358fa0bc7a3fc1ec5c41a6550efd1b72d5bf4fca
Author: Robert Swain <robert.swain@collabora.co.uk>
Date:   Fri Apr 15 11:16:42 2011 +0200

    edgetv: Remove unused but set height variable
    
    GCC 4.6.x spits warnings about such variables.