After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 647030 - [fpsdisplaysink] "silent" property
[fpsdisplaysink] "silent" property
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-07 13:01 UTC by Philippe Normand
Modified: 2011-04-08 12:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[fpsdisplaysink] verbose property (3.37 KB, patch)
2011-04-07 13:27 UTC, Philippe Normand
committed Details | Review

Description Philippe Normand 2011-04-07 13:01:25 UTC
It'd be nice to have a silent property set to FALSE by default. When set to TRUE the sink wouldn't print the stats to stdout.

Currently the stats are printed only if text overlay is disabled.
Comment 1 Philippe Normand 2011-04-07 13:26:27 UTC
Ah well, what about a "verbose" property set to FALSE by default?

It changes the behavior of the element a bit though. To enable stdout output:

old: fspdisplaysink text-overlay=FALSE
new: fpsdisplaysink verbose=TRUE

But it allows to have both text-overlay and stdout output. Not sure how useful that would be  ;)
Comment 2 Philippe Normand 2011-04-07 13:27:40 UTC
Created attachment 185421 [details] [review]
[fpsdisplaysink] verbose property

When this property is set to TRUE the element will display statistics
on stdout.

Fixes
Comment 3 Sebastian Dröge (slomo) 2011-04-08 12:12:29 UTC
commit a7cbd201b1924c39d1e54e383a8c8a6607e8e362
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Fri Apr 8 14:08:10 2011 +0200

    fpsdisplay: Use PROP_ instead of ARG_ for the property enums

commit 26bc5537cef13164f5396f4a33e0cb50da248d5b
Author: Philippe Normand <pnormand@igalia.com>
Date:   Thu Apr 7 15:15:57 2011 +0200

    fpsdisplay: Add verbose property
    
    When this property is set to TRUE the element will display statistics
    on stdout.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=647030