After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646925 - encoding-profile: Remove unused variables
encoding-profile: Remove unused variables
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal blocker
: 0.10.33
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-06 15:28 UTC by Bastien Nocera
Modified: 2011-04-12 09:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
encoding-profile: Remove unused variables (1.95 KB, patch)
2011-04-06 15:28 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2011-04-06 15:28:18 UTC
.
Comment 1 Bastien Nocera 2011-04-06 15:28:20 UTC
Created attachment 185321 [details] [review]
encoding-profile: Remove unused variables
Comment 2 Sebastian Dröge (slomo) 2011-04-07 08:10:13 UTC
Review of attachment 185321 [details] [review]:

::: gst-libs/gst/pbutils/encoding-target.c
@@ -456,3 @@
   profpreset = gst_encoding_profile_get_preset (prof);
-  proftype = gst_encoding_profile_get_type_nick (prof);
-  profrestriction = gst_encoding_profile_get_restriction (prof);

I think the nick and restrictions of profiles should be serialized/deserialized too. Edward?
Comment 3 Edward Hervey 2011-04-07 15:06:43 UTC
I think they are still taken into account in the whole code.
Comment 4 Tim-Philipp Müller 2011-04-11 17:24:30 UTC
> I think they are still taken into account in the whole code.

Where/how? Could you check please? Do "top-level" profiles never have restrictions (vs. "stream profiles")?

The type nick is taken into account (a few lines below), but I don't see the restriction being taken into account.
Comment 5 Edward Hervey 2011-04-11 19:54:34 UTC
only stream profiles have restrictions
Comment 6 Tim-Philipp Müller 2011-04-12 09:11:30 UTC
Pushed, thanks:

 commit 3fa0119dc13f8861f68f8b7b108ce137e3508d53
 Author: Bastien Nocera <hadess@hadess.net>
 Date:   Wed Apr 6 16:27:54 2011 +0100

    encoding-profile: fix unused-but-set-variable warnings with gcc 4.6
    
    Top-level profiles don't have restrictions, only stream profiles,
    so no need to serialise that here.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=646925

Also see bug  #647294 for gcc-4.6 related issues in -base.
Comment 7 Tim-Philipp Müller 2011-04-12 09:12:14 UTC
Comment on attachment 185321 [details] [review]
encoding-profile: Remove unused variables

Committed with minor changes (used proftype variable instead of removing it).