GNOME Bugzilla – Bug 644648
Doesn't correctly use sink volume control
Last modified: 2011-04-07 21:39:40 UTC
Some audio sinks have their own volume control (for example pulseaudio), unfortunately the detection for this in banshee sems broken atm
Created attachment 183281 [details] [review] Correctly detect sink volume control If an element is used as an audiosink which detects and dynamically plugs the actual sink element, then we can only detect sink volume support after this has happened. To trigger this, simply set the sink state to READY, which should open the resources and thus load the actual audio sink.
Created attachment 183282 [details] [review] Use the proper element for volume control
Created attachment 183283 [details] [review] Update our current volume the pipeline volume changes
Created attachment 183284 [details] [review] Remove dead code
Thanks Sjoerd, these patches look pretty good to me. Can you describe the testing/QA you've done with them applied? Have you tested with a sink that doesn't have its own volume control? When the sink does have its own volume, does Banshee's volume slider affect the overall system/Pulseaudio volume?
(In reply to comment #5) > Thanks Sjoerd, these patches look pretty good to me. Can you describe the > testing/QA you've done with them applied? Have you tested with a sink that > doesn't have its own volume control? It's a while ago, iirc i did test the other codepath (e.g. the pulseaudio volume control one). but i mostly focussed on the pulseaudio bits as that's what i cared about :) > When the sink does have its own volume, does Banshee's volume slider affect the > overall system/Pulseaudio volume? Banshees volume control will effect the volume of the banshee audio stream in pulseaudio. whether this effects the overall system volume is up to pulse. e.g. in the gnome volume control you should see the per applicaiton volume change if you use the banshee thing
Committed to master, thanks Sjoerd!