After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 644565 - Kill libmutter-private ?
Kill libmutter-private ?
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2011-03-12 15:27 UTC by Frederic Peters
Modified: 2011-03-17 14:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Kill libmutter-private (2.94 KB, patch)
2011-03-12 15:40 UTC, Frederic Peters
none Details | Review
Go with a single libmutter library (5.13 KB, patch)
2011-03-12 16:10 UTC, Frederic Peters
reviewed Details | Review
link gnome-shell against libmutter (1.54 KB, patch)
2011-03-17 13:31 UTC, Frederic Peters
none Details | Review

Description Frederic Peters 2011-03-12 15:27:27 UTC
I think libmetacity-private was created to the control center could render preview of metacity themes, in the appearance preferences; then it was used in compiz to draw window borders, it looks like it's now also used by monodevelop, probably to provide some lookalike windows.

Anyway, this is about mutter, and there is now a libmutter-wm with all necessary symbols; therefore I believe libmutter-private is not necessary, and could be killed.
Comment 1 Frederic Peters 2011-03-12 15:40:16 UTC
Created attachment 183212 [details] [review]
Kill libmutter-private
Comment 2 Frederic Peters 2011-03-12 15:41:41 UTC
(it depends on bug 644564 but this is trivial to exclude if requested)
Comment 3 Frederic Peters 2011-03-12 16:10:50 UTC
Created attachment 183215 [details] [review]
Go with a single libmutter library
Comment 4 Dan Winship 2011-03-17 13:25:48 UTC
Comment on attachment 183215 [details] [review]
Go with a single libmutter library

this probably makes sense, though of course we'd need a corresponding gnome-shell patch too.

owen?
Comment 5 Frederic Peters 2011-03-17 13:31:29 UTC
Created attachment 183624 [details] [review]
link gnome-shell against libmutter

That should do it; of course I can also open a bug against gnome-shell if you prefer.
Comment 6 Owen Taylor 2011-03-17 13:49:23 UTC
(In reply to comment #4)
> (From update of attachment 183215 [details] [review])
> this probably makes sense, though of course we'd need a corresponding
> gnome-shell patch too.
> 
> owen?

Mar 12 10:42:22 <fredp> owen: hi; what do you think of https://bugzilla.gnome.org/show_bug.cgi?id=644565 ?
Mar 12 10:42:23 <bebot> Bug 644565: normal, Normal, ---, mutter-maint, UNCONFIRMED, Kill libmutter-private ?
Mar 12 10:48:53 <magcius>       fredp, what is depending on libmutter-private, currently?
Mar 12 10:49:07 <fredp> magcius: nothing, afaik.
Mar 12 10:49:57 <fredp> perhaps there have been patches to update modules from libmetacity-private to libmutter-private
Mar 12 10:49:58 <owen>  fredp: what's the gain?
Mar 12 10:50:37 <fredp> one library in less.
Mar 12 10:50:56 <fredp> and that's a library that nobody is using.
Mar 12 10:50:56 <owen>  fredp: We don't need it in GNOME at the moment (unless gnome-plumbing tools need it), but it still seems like useful functionality f
or people building on top of mutter conceived as window-manager-construction-kit
Mar 12 10:51:12 <fredp> but libmutter-wm can provide this.
Mar 12 10:51:28 <fredp> (if preview-widget.c is added)
Mar 12 10:51:52 <magcius>       Can we guarantee that nobody currently is using libmutter-private, right now?
Mar 12 10:52:15 <fredp> magcius: perhaps you're secretly using it in a private project on your computer, I can't tell.
Mar 12 10:52:26 <fredp> but other than that, I know of no use.
Mar 12 10:52:39 <fredp> and they would just have to switch from libmutter-private to libmutter-wm
Mar 12 10:52:57 <fredp> we're still at 2.91, that felt like the time to do it.
Mar 12 10:56:30 <owen>  fredp: honestly, I just don't care very much, I thought I discussed it with danw in some detail a while ago, but our conversation se
ems to have been:
Mar 12 10:56:45 <owen>  Mar 04 15:01:56 <danw>  owen: is libmutter-private still useful?
Mar 12 10:56:51 <owen>  Mar 04 15:02:58 <owen>  danw: if 'gnome plumbing' will allow theme selection, will be needed
Mar 12 10:59:30 <owen>  fredp: if trimming 160k off the install size of gnome is important, I guess we can ditch it, though then libmutter-wm should be renamed to libmutter
Mar 12 11:00:02 <owen>  (see the initial comment on https://bugzilla.gnome.org/show_bug.cgi?id=643959)
Mar 12 11:00:04 <bebot> Bug 643959: normal, Normal, ---, mutter-maint, RESOLVED FIXED, Make mutter into a library
Mar 12 11:02:54 <fredp> owen: I'd like to go with a single libmutter, then, something I remembered is that will be easier to track library symbols.
Mar 12 11:07:38 <owen>  fredp: note that libmutter-wm and libmuter-private both have 0 compat guarantees
Mar 12 11:08:22 <fredp> owen: sure, and I don't ask for compat.
Mar 12 11:08:33 <owen>  then why do you want to track symbols?
Mar 12 11:09:13 <owen>  fredp: if you want to do that, can you extend your patch to rename libmutter-wm (don't need to do the corresponding gnome-shell) change and I'll double check with danw on monday. 
Mar 12 11:10:05 <fredp> even if there's no compat, it happens there are releases without api/abi changes, and it can make for less strict package dependencies, and easier upgrades.
Mar 12 11:11:39 <fredp> owen: and what about renaming Meta.gir to Mutter.gir :)
Mar 12 11:11:45 <owen>  No
Mar 12 11:11:48 <fredp> ok.

So, if you are OK with it, we're good to go.
Comment 7 Frederic Peters 2011-03-17 14:32:45 UTC
Pushed  both of them, modified as agreed on IRC; thanks!