After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 644156 - Greeter shows empty items in user list
Greeter shows empty items in user list
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2011-03-07 21:33 UTC by Ray Strode [halfline]
Modified: 2011-03-10 00:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
greeter: don't show empty names in user list (2.64 KB, patch)
2011-03-07 21:33 UTC, Ray Strode [halfline]
committed Details | Review
greeter: don't show empty names in user list (1.66 KB, patch)
2011-03-10 00:29 UTC, Ray Strode [halfline]
committed Details | Review

Description Ray Strode [halfline] 2011-03-07 21:33:46 UTC
If a user has no entry in the gecos field of the passwd file,
then we don't show them as having a blank name in the uesr list.

We should instead fall back to using username probably.
Comment 1 Ray Strode [halfline] 2011-03-07 21:33:47 UTC
Created attachment 182770 [details] [review]
greeter: don't show empty names in user list

If a user doesn't have a name in gecos, fall back to username.
Comment 2 Ray Strode [halfline] 2011-03-07 21:34:29 UTC
Attachment 182770 [details] pushed as f7978ec - greeter: don't show empty names in user list
Comment 3 Ray Strode [halfline] 2011-03-08 22:41:47 UTC
This still isn't working right, reopening.
Comment 4 Ray Strode [halfline] 2011-03-10 00:29:45 UTC
The following fix has been pushed:
8b91fee greeter: don't show empty names in user list
Comment 5 Ray Strode [halfline] 2011-03-10 00:29:48 UTC
Created attachment 183035 [details] [review]
greeter: don't show empty names in user list

If a user doesn't have a name in gecos, fall back to username.

This is similar to commit f7978ec4dd39d3c4aecb462bfc6d0657c7ed6f0d, but
functional instead of broken.