After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643407 - Properly handle errors in Gstreamer in Banshee.GstreamerSharp
Properly handle errors in Gstreamer in Banshee.GstreamerSharp
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: GStreamer
git master
Other Windows
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-02-27 12:07 UTC by Peter Johanson
Modified: 2011-02-27 20:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch implementing better Gstreamer error handling. (3.95 KB, patch)
2011-02-27 12:08 UTC, Peter Johanson 		needs-work Details | Review
Updated version against latest master (4.00 KB, patch)
2011-02-27 20:30 UTC, Peter Johanson 		committed Details | Review

Description Peter Johanson 2011-02-27 12:07:07 UTC 
In our bus message handler in Banshee.GstreamerSharp, the case of error bus messages is silently dropped. I will attach a patch that ports the code from Banshee.Gstreamer to handle the various gstreamer errors properly.
Comment 1 Peter Johanson 2011-02-27 12:08:49 UTC 
Created attachment 182036 [details] [review]
Patch implementing better Gstreamer error handling.
Comment 2 Gabriel Burt 2011-02-27 18:31:20 UTC 
Comment on attachment 182036 [details] [review]
Patch implementing better Gstreamer error handling.

Pete, this patch looks good, except it's not against current master.
Comment 3 Peter Johanson 2011-02-27 20:30:40 UTC 
Created attachment 182052 [details] [review]
Updated version against latest master

Forgot to "git fetch" before my last rebase. This should apply to current master fine.
Comment 4 Gabriel Burt 2011-02-27 20:39:19 UTC 
Comment on attachment 182052 [details] [review]
Updated version against latest master

Committed, thanks