GNOME Bugzilla – Bug 643389
Error opening some types of previously saved files
Last modified: 2011-09-19 23:05:54 UTC
Some types of subtitles written by the Gnome-Subtitles to a file, then they are not recognized at the opening. Applies to: MPSub.sub PhoenixJapanimationSociety.pjs Sofni.sub SubCreator1x.txt Type AQTitle.aqt opens, but it looks very bad;-)
Pawel, can you attach some examples?
Created attachment 182139 [details] samples
I enclose examples obtained in the configuration: WinXP_PL> VMware Player> Ubuntu10.10PL> Gnome-Subtitles1.1.0.3 Very quickly, you can test the conversion with the help SubLibGUI [Windows] http://sourceforge.net/projects/streaman/files/Useful_Tools/SubLib/ Click the "All Formats". The results are identical. Interesting fact: for conversion to MPsub, from “\gnome-subtitles\etc\samples\ CC Mayer and Bette Animation.srt” opens correctly and on my test file will not open!
I fixed those bugs now. Most of the mistakes come from the decimal point, others is redundant or missing characters in file formats. By the way I discovered a few other bugs, so cumulative patch send you a little later. In all the formats I want to improve: at the input - more liberal treatment the decimal separator - "[,.]" at the output - more restrictive treatment the decimal separator - "\." , so as to _not_ use System.Globalization.NumberFormatInfo.CurrentInfo.NumberDecimalSeparator.
Created attachment 189359 [details] [review] Proposed patch for #643389 I did as I wrote above. They should therefore not encounter some problems (and like #642674). Only (and the only one) floating point group ElapsedTime for MPsub uses CultureInfo.InvariantCulture in the input. But it's probably not a crime :-). At the exit none. Please do not hesitate to write to me if you will notice any similar errors.
Created attachment 190008 [details] [review] Revised proposed patch for #643389 I introduced amendments to AQTitle, MacSUB, SubCreator1x. I added more comments and marked the place where you will have to come back, eg in connection with #652412. It seems to me also reasonable to change the type FABSubtitler and AdobeEncoreDVD from time to frame based. Notation "hh:mm:ss:ff" only looks like time, but it is a number (integer) of frames. fn = (((hh*60)+mm)*60+ss)*FPS+ff Cheers, Paweł
Hi there Pawel, and sorry for taking so long to reply and review your patches. Thanks for your deep review of existing subtitle formats. You've found many bugs that really needed to be fixed. You can review the committed changes here: http://git.gnome.org/browse/gnome-subtitles/ . If you still find some bug, or a change I forgot to apply, please tell me. Those messages that should be displayed as warnings have been added as comments to the respective subtitle format class, and mentioned in bug #653677. I've also opened bug #658765 to deal with support for empty lines. Regarding Adobe Encore DVD and FAB Subtitler, the "Times" is needed for the parser to detect the parsing groups used. If we change to Frames, the only real benefit would be for "Frames mode" to be initially selected in Gnome Subtitles after opening these files. Btw, what do you mean with "Warning of necessary input the proper settings for FPS." ? Thanks again.
Hi Pedro! Format Phoenix Japanimation Society does not work yet. Text must be in quotes. Just as it corrected in the patch (id=190008). It seems to me that it too soon this bug was closed. As long as, a file saved by the GS can not be by GS opened, this bug is present. Identified problems: 1. Empty lines - excluded to Bug #658765 Support files with empty lines 2. To more lines in text: KaraokeLyricsVKT, KaraokeLyricsLRC, Panimator, Sofni. 3. To long time: AdvancedSubStationAlpha, KaraokeLyricsLRC, Panimator, SubStationAlpha. 4. Negative time: MPSub, Panimator. 5. Special characters: '#' in MPSub > Regarding AdobeEncoreDVD and FABSubtitler... I'll open a new bug to exclude from this thread. Cheers, Paweł
Pawel, thanks for noticing this. My fault for missing that part of your patch. 2. KaraokeLyricsVKT and KaraokeLyricsLRC don't support multiple lines, so this goes into bug #653677. Panimator actually had a problem with an extra blank line I've just fixed, but besides that, what problems with more lines do you see in Panimator and Sofni? 3. to 5. should also go into bug #653677. Cheers
Pedro, separate the two issues. The formal standard and open a file by GS. At the output - more restrictive - in accordance with the formal standard, can be corrected later. (Another matter that most often we don't have such formal detailed descriptions.) At the input - more liberal - can allow much more. To just do not generate an error by GS. And it is unacceptable that the error appeared when opening a file saved by GS. I only check that case now. Panimator and Sofni generate an error if the number of lines > 2. Cheers, Paweł
Sorry. Panimator and Sofni does not generate an error, just put lines > 2 (3, 4, ...) in the IncompleteSubtitles. But it is also a bug :-(
(In reply to comment #11) > Panimator and Sofni does not generate an error, just put lines > 2 (3, 4, ...) > in the IncompleteSubtitles. But it is also a bug :-( To be honest, I've considered removing that feature which I've never really used in Gnome Subtitles. Can you detail what text appears in IncompleteSubtitles? Is it empty text?
(In reply to comment #12) > (In reply to comment #11) > > Panimator and Sofni does not generate an error, just put lines > 2 (3, 4, ...) > > in the IncompleteSubtitles. But it is also a bug :-( > To be honest, I've considered removing that feature which I've never really > used in Gnome Subtitles. Oh no! Only recently I started to use, and may prove more useful than you think. > Can you detail what text appears in > IncompleteSubtitles? Is it empty text? No, usually not empty. It's hard to describe, you better check yourself. Soon as possible, these: http://sourceforge.net/projects/streaman/files/Useful_Tools/SubLib/
Alright, Sofni and Panimator are now fixed. About incomplete subtitles, the best will be to create a new bug if text still appears as incomplete.
Alright, Sofni and Panimator accept even the 4 lines :-) But MACSub still only 2 :-( Besides, due to too many lines, nothing jumps to the incomplete subtitles. By the way, testing whether the incomplete subtitles is empty when you open the file, gives the important confirmation that all OK. If it contains whatever, could at least give a message to the user.
Pawel, MacSUB is also fixed now. Did you detect any other error related to this bug?
Everything OK. :-)