After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 639772 - [volume OSD] use -symbolic icons
[volume OSD] use -symbolic icons
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: media-keys
2.91.x
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2011-01-17 18:17 UTC by Luca Ferretti
Modified: 2011-01-18 17:20 UTC
See Also:
GNOME target: 3.0
GNOME version: ---

Attachments
a patch (2.86 KB, patch)
2011-01-18 13:45 UTC, Matthias Clasen 		none Details | Review
media-keys: Use symbolic icons for OSD (4.69 KB, patch)
2011-01-18 16:22 UTC, Bastien Nocera 		committed Details | Review
screenshot (6.83 KB, image/png)
2011-01-18 16:26 UTC, Bastien Nocera 		  Details

Description Luca Ferretti 2011-01-17 18:17:54 UTC 
As suggested in GNOME 3.x design pages, the OSD for volume level should use symbolic icons

See related section in http://live.gnome.org/GnomeShell/Design/Whiteboards/SymbolicIcons/UseGuidelines
Comment 1 Matthias Clasen 2011-01-18 13:45:03 UTC 
Created attachment 178624 [details] [review]
a patch
Comment 2 Bastien Nocera 2011-01-18 16:22:57 UTC 
Created attachment 178635 [details] [review]
media-keys: Use symbolic icons for OSD

Prefer symbolic icons in the OSD. Use the new "use-fallback" property
of GtkImage to make sure that the fallback icons will be loaded if
necessary.
Comment 3 Bastien Nocera 2011-01-18 16:26:42 UTC 
Created attachment 178636 [details]
screenshot

This shows the problems with the mute icon, when using the above patch.
Comment 4 Bastien Nocera 2011-01-18 17:20:03 UTC 
Also added a separate patch to add padding between the icon and the meter.

Attachment 178635 [details] pushed as 5f4304d - media-keys: Use symbolic icons for OSD