GNOME Bugzilla – Bug 638541
Banshee looks for subtitles on audio files
Last modified: 2011-02-17 19:02:00 UTC
I'm using Banshee and BCE from Ubuntu daily/unstable ppas. I see the following when playing an audio file: [1 Debug 23:03:20.771] Player state change: Idle -> Loading [1 Debug 23:03:20.773] (libbanshee:player) [subtitle]: lookup for subtitle for video file. This seems rather useless as I don't think banshee actually does anything with such a file if found. It might be a good idea to only lookup subtitles for streams containing video.
Confirming, Olivier wrote that code so he earns a CC.
This should be a really simple fix -- if the track doesn't have the VideoStream attribute, don't look for subtitles. Needs to be fixed before 2.0.
simple fix add bp_stream_has_video in banshee-player-pipeline.h and use it in banshee-player.c / bp_open before lookup for sub. Just have to check if get the n-video can be done just after set the uri... maybe have to wait that file is loaded ==> after state change
Fixed in master