After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 638541 - Banshee looks for subtitles on audio files
Banshee looks for subtitles on audio files
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Playback
unspecified
Other Linux
: High normal
: 2.0
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-01-02 22:12 UTC by Christoph Wolk
Modified: 2011-02-17 19:02 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Christoph Wolk 2011-01-02 22:12:38 UTC
I'm using Banshee and BCE from Ubuntu daily/unstable ppas.

I see the following when playing an audio file:

[1 Debug 23:03:20.771] Player state change: Idle -> Loading
[1 Debug 23:03:20.773] (libbanshee:player) [subtitle]: lookup for subtitle for video file.

This seems rather useless as I don't think banshee actually does anything with such a file if found. It might be a good idea to only lookup subtitles for streams containing video.
Comment 1 David Nielsen 2011-01-08 12:16:40 UTC
Confirming, Olivier wrote that code so he earns a CC.
Comment 2 Gabriel Burt 2011-01-12 23:24:45 UTC
This should be a really simple fix -- if the track doesn't have the VideoStream attribute, don't look for subtitles.  Needs to be fixed before 2.0.
Comment 3 olivier dufour 2011-01-13 11:12:45 UTC
simple fix add bp_stream_has_video  in banshee-player-pipeline.h
and use it in banshee-player.c / bp_open before lookup for sub.
Just have to check if get the n-video can be done just after set the uri...
maybe have to wait that file is loaded ==> after state change
Comment 4 Gabriel Burt 2011-02-17 19:02:00 UTC
Fixed in master