Created attachment 176486 [details] [review]
theme: Add tiled_left/tiled_right frame states

It may be desirable for theme authors to treat side-by-side tiled
windows differently, for instance to give the edge-touching border
a width of 0, so add additional frame states for tiled windows.

Review of attachment 176486 [details] [review]:

Few questions

::: src/ui/theme.c
@@ +4831,3 @@
             break;
+          case META_FRAME_STATE_TILED_LEFT:
+            styles = style_set->tiled_left_styles;

Shouldn't there be some sort of fallback here so things work with old themes?

@@ +4919,3 @@
     return FALSE;
 
+#if 0

Unclear why you are adding #if 0'd code

Created attachment 177535 [details] [review]
theme: Add tiled_left/tiled_right frame states

(In reply to comment #2)
> Review of attachment 176486 [details] [review]:
> 
> Few questions
> 
> ::: src/ui/theme.c
> @@ +4831,3 @@
>              break;
> +          case META_FRAME_STATE_TILED_LEFT:
> +            styles = style_set->tiled_left_styles;
> 
> Shouldn't there be some sort of fallback here so things work with old themes?

Hmm, yeah - there seems to be an implicit fallback to the normal frame style (haven't tested with shaded), but should be explicit.



> @@ +4919,3 @@
>      return FALSE;
> 
> +#if 0
> 
> Unclear why you are adding #if 0'd code

Sorry - it was meant along the lines of "I didn't overlook that we check frame styles, but the new ones should be optional in my opinion". I deleted the #if'ed out code.

Review of attachment 177535 [details] [review]:

Looks good

Attachment 177535 [details] pushed as ed99d12 - theme: Add tiled_left/tiled_right frame states