After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 636699 - [PLUGIN-MOVE] qtmux: move to -good
[PLUGIN-MOVE] qtmux: move to -good
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal blocker
: 0.10.29
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-12-07 12:57 UTC by Mark Nauwelaerts
Modified: 2011-04-21 22:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
qtmux: remove large-file property (6.03 KB, patch)
2010-12-07 13:01 UTC, Mark Nauwelaerts
committed Details | Review
qtmux: default to dts-method=reorder and presentation-time=true (2.39 KB, patch)
2011-04-13 14:07 UTC, Tim-Philipp Müller
committed Details | Review

Description Mark Nauwelaerts 2010-12-07 12:57:32 UTC
Should fit requirements, i.e. has unit test, documentation and is already used extensively "in production".

There are some bugs filed against it, though no more so than on other components in -good or -base.  Moreover, most if not all of these actually require core (or 0.11) changes (e.g. downstream seekability, sparse stream / newsegment handling).
Comment 1 Mark Nauwelaerts 2010-12-07 13:01:48 UTC
Created attachment 176004 [details] [review]
qtmux: remove large-file property

Prior to moving, the properties might be "cleaned up" a bit though.

For instance, attached patch removes the large-file property, since qtmux can determine on its own if 64-bit stuff is needed to come up with a valid file.

Also, some mentioning of progressive-download (in stead of or in addition to faststart) might be helpful.
Comment 2 Mark Nauwelaerts 2011-04-04 10:11:51 UTC
Some minor additional points to consider pre/post move:
* check error/warning bus messages for "informativeness" and internalization
* consider using e.g. dts-method=reorder as default dts/pts handling method
Comment 3 Tim-Philipp Müller 2011-04-12 12:49:32 UTC
> * consider using e.g. dts-method=reorder as default dts/pts handling method

What's the best / safest default ?

I think we want to error out instead of creating broken files, but otherwise accept as much as possible without user needing to fiddle with stuff (main use cases: x264enc ! mux and transmuxing I guess?)
Comment 4 Mark Nauwelaerts 2011-04-12 14:13:24 UTC
"Normal expected" input that presented no problem for the current default should not pose a problem for reorder, and the latter can handle a few cases that have been popping up as a problem for the former.

That is not to say some input can be imagined that might confuse reorder, but not the current, but those are likely quite theoretical.

Suffice it to say, "broken" is relative, e.g. x264enc ! mux should come out ok in both cases (current or reorder, assuming there are durations in the former), but some players might have problems (e.g. QuickTime) unless pts are also provided, i.e. presentation-time=true (which is slightly different but quite related matter).

So, altogether, dts-method=reorder presentation-time=true as new default likely handle (typical cases) best/ok, and no immediate other problems foreseen (though no guarantee here as it has not been "out there" as default).
Comment 5 Tim-Philipp Müller 2011-04-13 11:44:49 UTC
Ok, the move itself is done:

 commit 4d780297d86c8209d8ee6fed7d6192faf79ced22
 Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
 Date:   Wed Apr 13 11:25:11 2011 +0100

    quicktime: move qtmux plugin from -bad to -good
    
    https://bugzilla.gnome.org/show_bug.cgi?id=636699


 commit 9f6dd0ba600994df092ab790dd758c1ee39ce41d
 Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
 Date:   Tue Apr 12 21:47:14 2011 +0100

    qtmux: remove qtmux plugin, it has moved to -good
    
    https://bugzilla.gnome.org/show_bug.cgi?id=636699


Remaining (most can be done after the first prerelease):

 - docs: add docs for generated *mux elements (mp4mux, gppmux etc.)

 - rename gppmux to 3gppmux or add additional 3gppmux?

 - come up with better (boolean-ish) name for "presentation-time"?

 - default to dts-method=reorder and presentation-time=true
   (seems to break unit tests, so needs updates there as well)
Comment 6 Tim-Philipp Müller 2011-04-13 14:07:25 UTC
Created attachment 185871 [details] [review]
qtmux: default to dts-method=reorder and presentation-time=true

This breaks the unit tests it seems.
Comment 7 Tim-Philipp Müller 2011-04-15 11:33:15 UTC
Comment on attachment 185871 [details] [review]
qtmux: default to dts-method=reorder and presentation-time=true

Mark fixed up test and qtmux a bit, so pushed this now:

commit c8b501489285aa8772831579c293dcd533e731fd
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Wed Apr 13 12:37:09 2011 +0100

    qtmux: default to dts-method=reorder and presentation-time=true
    
    https://bugzilla.gnome.org/show_bug.cgi?id=636699

commit 5f051fd996b55a41cbc32280f530c44870bc5835
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Fri Apr 15 12:47:52 2011 +0200

    tests: qtmux: test various dts-methods

commit 4df05e76ed5133482b0e1c57c63ef71ca31539ee
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Fri Apr 15 12:34:05 2011 +0200

    qtmux: fix corner case buffer handling for reorder method
Comment 8 Tim-Philipp Müller 2011-04-21 22:32:45 UTC
> Remaining (most can be done after the first prerelease):
> 
>  - docs: add docs for generated *mux elements (mp4mux, gppmux etc.)

Done:

 commit 3346a53374135b8a58a50f2ff18e0ecaaf2272d4
 Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
 Date:   Thu Apr 21 23:30:26 2011 +0100

    docs: add various qtmux variants to documentation


>  - rename gppmux to 3gppmux or add additional 3gppmux?

Done:

 commit 0671b2325e7b4256d474283b4d4fb1f3c9ea0169
 Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
 Date:   Thu Apr 21 22:51:52 2011 +0100

    quicktime: register 3gppmux element in addition to the misnamed gppmux

 
>  - come up with better (boolean-ish) name for "presentation-time"?

Not done / don't care if no one has ideas.

>  - default to dts-method=reorder and presentation-time=true
>    (seems to break unit tests, so needs updates there as well)

Done/fixed.