After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 636450 - Ripping CD Error - Filename too long
Ripping CD Error - Filename too long
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Importing
1.8.0
Other Linux
: Normal major
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
: 656401 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-12-04 14:10 UTC by Andrew Wild
Modified: 2012-09-12 19:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
log of failure (at the end of the log) (20.66 KB, text/plain)
2012-01-07 09:02 UTC, Rune Schjellerup Philosof
  Details
truncate filename to 200 characters (1.10 KB, patch)
2012-09-02 21:30 UTC, Roderich Schupp
committed Details | Review

Description Andrew Wild 2010-12-04 14:10:51 UTC
Hey guys,

So I was trying to rip my music collection in Banshee, and all was well, untill I popped in my Sufjan Stevens - Illinoise album. If you know this one, the second track has a ridiculously long track title. Moments after I "Import the CD" I am greeted by the error message and Banshee crashes. 

Now I tried looking at the settings for an easy fix but all of the options to change the filename that banshee formats on import involve the track title, so no help there. I then tried to disable all functions that require the internet hoping that the metadata wouldn't load so I could specify my own, no dice there either. Finally I found that I had to physically unplug my ethernet to stop the metadata from mucking up the works.

Moral of the story: Banshee needs to be able to truncate filenames.

I dont know the scope of this issue; I am running Banshee 1.8.0 on Ubuntu 10.10 and in case the log file doesnt specify I was trying to import in FLAC (If that makes a difference). Keep up the great work, congrats on becoming the new default on the Ubuntu OS.

-Andy-
Comment 1 David Nielsen 2010-12-05 04:22:07 UTC
A debug log is required to examine your issue. 

Please run banshee-1 --debug --redirect-log

and reproduce the issue and exit Banshee. Then attach the resulting
~/.config/banshee-1/log file.

Also if you could try the most recent Banshee to confirm that the issue is still present it would be great. You can use the Banshee daily PPA for this purpose.

https://launchpad.net/~banshee-team/+archive/banshee-daily
Comment 2 Fabio Durán Verdugo 2011-01-20 03:34:18 UTC
Closing this bug report as no further information has been provided. Please feel free to reopen this bug if you can provide the information asked for.
Thanks!
Comment 3 Rune Schjellerup Philosof 2012-01-07 09:02:33 UTC
Created attachment 204801 [details]
log of failure (at the end of the log)

For some reason I cannot reopen this bug.
Here is a log from daily on oneiric.

These kinds of problems should not make the entire program crash. The problem should merely make banshee skip that file and report the error to the user.

In this case banshee should suggest a solution, truncation for instance, or ask for a name from the user.
Comment 4 Roderich Schupp 2012-09-02 21:30:58 UTC
Created attachment 223218 [details] [review]
truncate filename to 200 characters
Comment 5 Roderich Schupp 2012-09-02 21:34:33 UTC
Hit this bug also with Sufjan Stevens' album "Illinois"
(http://musicbrainz.org/release/b14f3252-4973-3fe0-a4da-af5d39626cc1),
the title of track 2 is actually 288 characters long -
too long for Linux where NAME_MAX is 255.

Proposed solution: simply truncate the file's name (before the extension)
to something reasonably supported by all filesystems, say 200.
Comment 6 Bertrand Lorentz 2012-09-12 18:02:51 UTC
*** Bug 656401 has been marked as a duplicate of this bug. ***
Comment 7 Bertrand Lorentz 2012-09-12 19:20:22 UTC
Comment on attachment 223218 [details] [review]
truncate filename to 200 characters

Thanks for the patch!
Committed with some minor changes:
http://git.gnome.org/browse/banshee/commit/?id=f24e62a29
Comment 8 Bertrand Lorentz 2012-09-12 19:20:38 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.