GNOME Bugzilla – Bug 635780
Selecting source category expands source selector to entire window
Last modified: 2010-12-02 04:13:22 UTC
Created attachment 175240 [details] The expanded source selector If using the keyboard to navigate the source selector, when one of the categories is selection, the source selector expands to take the full Banshee window
Created attachment 175262 [details] [review] Sets the treeview SelectionFunc to not allow GroupSources as valid selections
Created attachment 175271 [details] [review] Makes keyboard scrolling on the source selector skip group sources completely
Review of attachment 175271 [details] [review]: The patch works, but it introduces a regression -- when clicking on the divider the source panel expands for a short moment. ::: src/Core/Banshee.ThickClient/Banshee.Sources.Gui/SourceView.cs @@ +91,3 @@ + Selection.SelectFunction = (selection, model, path, selected) => + { Move `{` to the line above: `=> {` @@ +219,3 @@ + protected override bool OnKeyPressEvent (Gdk.EventKey press) + { + Source source; It's not C, define variable as you need them. Also, use `var`. @@ +236,3 @@ + movedCursor = true; + } + /* Remove commented out code. @@ +421,2 @@ Source new_source = store.GetValue (iter, (int)SourceModel.Columns.Source) as Source; + Trailing whitespace. ::: src/Extensions/Banshee.Podcasting/Makefile.am @@ +30,2 @@ Banshee.Podcasting.Gui/PodcastSourceContents.cs \ + Banshee.Podcasting.Gui/PodcastUnheardFilterView.cs \ Commit this separately.
::: src/Extensions/Banshee.Podcasting/Makefile.am @@ +30,2 @@ Banshee.Podcasting.Gui/PodcastSourceContents.cs \ + Banshee.Podcasting.Gui/PodcastUnheardFilterView.cs \ Commit this separately. I don't know where this came from. MD must have done it for me and I didn't notice. Sorry! Everything else is now fixed.
Created attachment 175284 [details] [review] Update for alexk's review
Review of attachment 175284 [details] [review]: I'm still seeing the regression mentioned in the previous review: try clicking on the divider with your mouse, the source tree expands for 100-200 ms. ::: src/Core/Banshee.ThickClient/Banshee.Sources.Gui/SourceView.cs @@ +222,3 @@ + + Selection.GetSelected (out iter); + Treepath path = store.GetPath (iter); Should be `TreePath`. Or just use `var`.
I don't understand what divider you're talking about. I've clicked all over the source view and can't get it to expand.
Created attachment 175643 [details] [review] Fix expand on click regression
Review of attachment 175643 [details] [review]: Looks good, please commit.