After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 635088 - add MassStorageDevice definition for LG Ally Android phone
add MassStorageDevice definition for LG Ally Android phone
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Device - USB Mass Storage
git master
Other Linux
: Normal enhancement
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-11-17 16:52 UTC by Aran Cox
Modified: 2010-11-29 21:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
add MassStorageDevice definition for LG Ally Android phone (1.22 KB, patch)
2010-11-17 16:52 UTC, Aran Cox
committed Details | Review
0001-add-the-non-debug-usb-id-for-LG-Ally-Android-phone.patch (1.13 KB, patch)
2010-11-29 15:47 UTC, Aran Cox
committed Details | Review

Description Aran Cox 2010-11-17 16:52:38 UTC
Created attachment 174693 [details] [review]
add MassStorageDevice definition for LG Ally Android phone

This patch adds a MassStorageDevice for the LG Ally Android phone.

This was tested on my (surprise) LG Ally phone.  Without it I can't sync playlists and the like.
Comment 1 David Nielsen 2010-11-22 02:02:43 UTC
I may be wrong but wouldn't the best solution be to get this into media-player-info?

http://ernstfamily.ch/jonathan/2010/10/help-me-make-your-music-player-or-phone-recognized-as-such-under-linux/
Comment 2 Jonathan Ernst 2010-11-24 08:05:14 UTC
Thanks for letting me know about this bug report David.

I have added the ID to usb.ids and pushed the infos in m-p-i.

@Aran Cox

1) could you check if your device has other usb ids when (if available)

a) set up in mass storage with usb debug mode enabled (or disabled if it was enabled before) (on my Android phone it's in settings->applications->development->USB debug

b) set up in other USB modes (with name and corresponding usb id)

2) Do you know what playlist formats your device understands (e.g. audio/mpegurl;audio/x-mpegurl;audio/x-scpls) and if the playlists should be stored in a specific folder (e.g. Playlists/)

3) Did I get the formats right in my commit?
http://cgit.freedesktop.org/media-player-info/commit/?id=e6be4669d0a088a788bf627b751f42d24d19b31b

Thanks a lot for your help, this will not only help LG Ally Banshee users but most free-software using LG Ally users.
Comment 3 Bertrand Lorentz 2010-11-26 22:22:59 UTC
Comment on attachment 174693 [details] [review]
add MassStorageDevice definition for LG Ally Android phone

Thanks for the patch, I committed it to git master.
Comment 4 Bertrand Lorentz 2010-11-26 22:31:39 UTC
I'm marking this as fixed, as the patch is in Banshee's git and in media-player-info.

Aran, it would still be nice if you could answer Jonathan's questions, either here or directly by e-mail.
Comment 5 Aran Cox 2010-11-29 15:02:51 UTC
1) I checked the usb id with debug disabled (it was previously enabled) and it's still: 
Bus 001 Device 007: ID 1004:618f LG Electronics, Inc. 

2) Banshee treats all android devices the same (I think.)  It creates .m3u files in Music/Playlists/list.m3u with relative paths like:

../Someband/Somealbum/Sometrack.mp3

I don't know if my phone supports other formats of playlists or not but what banshee does works!

3) The format list looks good to me.  My phone will play flac files as well but I wouldn't want flac listed as a supported format or banshee won't transcode them.
Comment 6 Aran Cox 2010-11-29 15:47:44 UTC
Created attachment 175476 [details] [review]
0001-add-the-non-debug-usb-id-for-LG-Ally-Android-phone.patch
Comment 7 Aran Cox 2010-11-29 15:48:12 UTC
Sorry, the USB ID was different for non-debug mode so I attached a patch to add that.
Comment 8 Bertrand Lorentz 2010-11-29 21:10:36 UTC
Comment on attachment 175476 [details] [review]
0001-add-the-non-debug-usb-id-for-LG-Ally-Android-phone.patch

Thanks for the update, committed !

Hehe, I should have waited for your answer before committing the first patch ;)