After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 634647 - Banshee's search field doesn't respond predictably to Ctrl+a
Banshee's search field doesn't respond predictably to Ctrl+a
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: general
git master
Other Linux
: Normal trivial
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
: 638981 641769 648417 653539 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-11-12 00:00 UTC by Michael Martin-Smucker
Modified: 2011-06-28 12:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Allows Ctrl-A to select text in SearchEntry box (1.44 KB, patch)
2011-04-09 04:02 UTC, Mackenan Grassi
committed Details | Review

Description Michael Martin-Smucker 2010-11-12 00:00:46 UTC
Steps:

1. Open Banshee
2. Click on the search field to focus it
3. Type some characters that return no results
4. Press ctrl+a to select everything in the search field
5. Noticing that nothing happens, ensure that the search field is focused and try again
6. Still no luck

This seemed like a straightforward bug until I tried:

1. Open Banshee
2. Click on the search field to focus it
3. Type some characters that return results
4. Press ctrl-a, expecting to select the text in the search field, which has focus. Instead all of the tracks that match the search are selected.
5. Press ctrl-a again, just for kicks.  At this point, the text in the search field is finally selected.

I'm guessing this was intentional, to make it easier to select all tracks after performing a search, but in my opinion, this is not very intuitive.  I expect the shortcut to apply to the field with focus.  The problem is even worse when the search returns no results.  It seems logical at that point to select your text so you can try another search, but the shortcut doesn't work at all in that scenario.
Comment 1 Michael Martin-Smucker 2011-01-08 13:53:35 UTC
*** Bug 638981 has been marked as a duplicate of this bug. ***
Comment 2 Michael Martin-Smucker 2011-02-07 19:59:33 UTC
*** Bug 641769 has been marked as a duplicate of this bug. ***
Comment 3 Mackenan Grassi 2011-04-09 04:02:04 UTC
Created attachment 185570 [details] [review]
Allows Ctrl-A to select text in SearchEntry box

Banshee's OnKeyPressEvent function disables all hotkeys if an Entry widget has focus. This hotkey disabling is skipped if the Ctrl key is pressed to allow things like Ctrl-L to continue to work. I added a conditional that only allows that to happen if Ctrl is not hit in combination with 'a'. This way, Ctrl-A can function normally inside an Entry widget.
Comment 4 Gabriel Burt 2011-04-12 16:56:24 UTC
Review of attachment 185570 [details] [review]:

Committed, thanks
Comment 5 Michael Martin-Smucker 2011-04-21 19:44:02 UTC
*** Bug 648417 has been marked as a duplicate of this bug. ***
Comment 6 Michael Martin-Smucker 2011-06-28 12:25:21 UTC
*** Bug 653539 has been marked as a duplicate of this bug. ***