After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 634063 - Clearing Files Queue deletes entries from DB
Clearing Files Queue deletes entries from DB
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Importing
2.4.0
Other Linux
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-11-05 10:39 UTC by Misha Shnurapet
Modified: 2012-05-19 18:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
general information (2.74 KB, text/x-log)
2010-11-05 10:39 UTC, Misha Shnurapet
Details
debug log (8.64 KB, text/plain)
2011-02-16 11:49 UTC, Misha Shnurapet
Details
database debug log (139.17 KB, text/plain)
2011-02-16 11:49 UTC, Misha Shnurapet
Details

Description Misha Shnurapet 2010-11-05 10:39:13 UTC
Created attachment 173873 [details]
general information

When I drag'n'drop the files queue item onto the audio collection item, the files are moved but not being added to the database. After the program restart it is impossible to find them, though the files reside where they should be (in collection folder) and are renamed properly.
Comment 1 Michael Martin-Smucker 2011-02-15 21:10:20 UTC
Let me make sure I'm understanding this correctly.

  1. You open a file from your file system into Banshee's File System Queue.
  2. You drag and drop these songs into the main Library.
  3. Banshee doesn't list the files (despite the fact that they were correctly copied into the right folder structure if you have Banshee set to manage your file organization).

If that's the case, it sounds like an important piece of the FSQ is pretty broken.  Could you retest with Banshee 1.9.3 or a recent daily build or git master?  Also, could you attach a debug log following the directions here: http://live.gnome.org/Banshee/CommonQuestions/Logs

Thanks in advance (and sorry you didn't get a response sooner)!
Comment 2 Misha Shnurapet 2011-02-16 11:48:44 UTC
Yes, that is correct. Updated to git master.
Comment 3 Misha Shnurapet 2011-02-16 11:49:23 UTC
Created attachment 180984 [details]
debug log
Comment 4 Misha Shnurapet 2011-02-16 11:49:52 UTC
Created attachment 180986 [details]
database debug log
Comment 5 Misha Shnurapet 2011-04-13 16:54:40 UTC
Same issue on 2.0.

Clearing the files queue discards files from the library.
Comment 6 Misha Shnurapet 2011-06-15 10:57:11 UTC
banshee-2.0.1-2.fc15.i686

(In reply to comment #1)
> Let me make sure I'm understanding this correctly.
> 
>   1. You open a file from your file system into Banshee's File System Queue.
>   2. You drag and drop these songs into the main Library.
>   3. Banshee doesn't list the files (despite the fact that they were correctly
> copied into the right folder structure if you have Banshee set to manage your
> file organization).

3. Banshee DOES list the files, now both on the Files Queue and in the database. The files are copied and renamed correctly. But the database record is gone as soon as the Files Queue is cleared. The button that clears the Files Queue messes up the database. In the end the files reside in the Music folder, but won't be listed anymore.
Comment 7 Misha Shnurapet 2012-04-12 03:16:09 UTC
Sorry if I offended anyone.

Here's what happens in 2.4:

1. Add songs to the files queue
2. Import the files queue

The songs are imported. The files queue stays filled.

3. Press the button that clears the files queue.

The files queue is cleared and the library entries for the imported instance are gone. It should also be safe to clear the files queue. It currently results in deletion of the library entries for the songs actually imported.

It would also be nice to remove the songs from the files queue automatically on import.
Comment 8 Bertrand Lorentz 2012-05-19 17:54:33 UTC
Thank you for your bug report and your persistence.
You didn't offend anyone, your bug just slipped off everyone's radar.

I was able to reproduce the problem.

Here's what's happening:
When you drag a track from the FSQ (File System Queue), the entry for this track in the database is just updated to attach it to the music library, it keeps the same TrackId.
At this point it's not really in the FSQ anymore, but it's still in the FSQ's cache. So when you clear the FSQ, it's still going to delete the row with the TrackId from the database.

So we need to find a way to update the FSQ when tracks are imported.
Comment 9 Bertrand Lorentz 2012-05-19 18:40:25 UTC
This problem has been fixed in the development version. The fix will be available in the next software release. Thank you for your bug report.

We now refresh the FSQ when tracks are imported, so its content is up-to-date.