After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 631814 - [flacparse] unit test failures
[flacparse] unit test failures
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal blocker
: 0.10.21
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 616921
 
 
Reported: 2010-10-10 12:52 UTC by Tim-Philipp Müller
Modified: 2010-10-12 08:32 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Tim-Philipp Müller 2010-10-10 12:52:17 UTC
Running suite(s): flacparse
16%: Checks: 6, Failures: 5, Errors: 0
elements/parser.c:274:F:general:test_parse_flac_normal:0: 'g_list_length (buffers) - test->discard' (1) is not equal to 'frames' (10)
elements/parser.c:274:F:general:test_parse_flac_drain_garbage:0: 'g_list_length (buffers) - test->discard' (0) is not equal to 'frames' (1)
elements/parser.c:274:F:general:test_parse_flac_split:0: 'g_list_length (buffers) - test->discard' (1) is not equal to 'frames' (20)
elements/parser.c:274:F:general:test_parse_flac_skip_garbage:0: 'g_list_length (buffers) - test->discard' (1) is not equal to 'frames' (20)
elements/parser.c:274:F:general:test_parse_flac_detect_stream:0: 'g_list_length (buffers) - test->discard' (1) is not equal to 'frames' (10)
FAIL: elements/flacparse
Comment 1 Mark Nauwelaerts 2010-10-11 15:30:26 UTC
Commit below fixes the common parsing cases.

However, the remaining drain_garbage and skip_garbage are another story, since the new approach can't handle those cases, i.e. really dig up the correct frames.  Only real way to fix those may be to always calculate CRC and fallback to old code if mismatch detected, but that was likely not the idea of the revision ...  So we may have to end up not caring about those cases ?


----
commit 11bdf1def1dbc1e9fa37ab725497897489ecb700
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Mon Oct 11 17:06:48 2010 +0200

    flacparse: fix parsing with unknown framesizes
    
    Fixes #631814 (mostly).
Comment 2 Sebastian Dröge (slomo) 2010-10-12 08:32:05 UTC
commit e8341d2129c52b6d6b4ffb02587055134565ded9
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Tue Oct 12 10:28:33 2010 +0200

    flacparse: Adjust unit tests to new flacparse behaviour
    
    Garbage after frames is now included in the frames because flacparse
    has no easy way to detect the real end of a frame. Decoders are
    expected to everything after the frame because only decoding the
    bitstream will reveal the real end of the frame.
    
    Fixes bug #631814.

commit f576c3f1288b810691f2e7c72b275d91eb2a7a61
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Tue Oct 12 10:27:53 2010 +0200

    flacparse: Don't drop the last frame if it is followed by garbage
    
    See bug #631814.