After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 631189 - Server appears to hang when parsing XSLT (let's port to lxml)
Server appears to hang when parsing XSLT (let's port to lxml)
Status: RESOLVED FIXED
Product: snowy
Classification: Deprecated
Component: Tomboy Online
git master
Other All
: Urgent blocker
: private alpha
Assigned To: snowy-maint
snowy-maint
Depends on:
Blocks:
 
 
Reported: 2010-10-02 19:15 UTC by Sandy Armstrong
Modified: 2010-10-09 09:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to port us to lxml (4.93 KB, patch)
2010-10-02 19:44 UTC, Sandy Armstrong
none Details | Review
Update for 0.3 (1.14 KB, patch)
2010-10-04 17:56 UTC, Jeff Schroeder
rejected Details | Review

Description Sandy Armstrong 2010-10-02 19:15:31 UTC
I don't know when this started happening or why, but with complete consistency edge.tomboy-online.org fails when trying to show note pages.

It appears to hang when parsing the XSL file.

I couldn't figure this out in 5 minutes, and since we've been wanting to use lxml in Snowy anyway, I went ahead and ported this code to use lxml.  Attachment on the way.
Comment 1 Sandy Armstrong 2010-10-02 19:29:27 UTC
Not attaching the patch yet.  Further testing on edge shows that there are sporadic errors when extension functions are called.  Researching now.
Comment 2 Sandy Armstrong 2010-10-02 19:44:07 UTC
Let me explain this new error.

0) Apply my patch
1) Sync some note that link to other notes
2) In Snowy, try to view a note that links to other notes

Result: ~3/4 times, I would get the following server error:

"cannot unmarshal code objects in restricted execution mode"


This problem is explained here: http://code.google.com/p/modwsgi/wiki/ApplicationIssues#Multiple_Python_Sub_Interpreters

It has to do with how lxml calls back extension functions.  There is a whole thread about it (where the solution they talk about is modpython-specific):
http://codespeak.net/pipermail/lxml-dev/2007-September/002954.html

For WSGI, he fix was to add this line in the Apache config file (see first link for details):

WSGIApplicationGroup %{GLOBAL}

I'd like confirmation from Jeff that this is okay.  Otherwise, I'll have to modify our approach to not use any extension functions, which is less than ideal from my point of view.
Comment 3 Sandy Armstrong 2010-10-02 19:44:58 UTC
Created attachment 171587 [details] [review]
Patch to port us to lxml
Comment 4 Jeff Schroeder 2010-10-02 21:14:46 UTC
Your patch is a motd for Debian i686 fyi. See my convo in IRC.
Comment 5 Jeff Schroeder 2010-10-04 17:56:21 UTC
Created attachment 171711 [details] [review]
Update for 0.3
Comment 6 Jeff Schroeder 2010-10-04 17:57:27 UTC
Review of attachment 171711 [details] [review]:

I fail at git bz
Comment 7 Jeff Schroeder 2010-10-04 18:06:12 UTC
Review of attachment 171587 [details] [review]:

Works fine for me.

Tested-by: Jeff Schroeder <jeffschroeder@computer.org>
Comment 8 Sandy Armstrong 2010-10-09 09:27:10 UTC
Oh, right, we fixed this in 0.4.