After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630671 - prepare mutter for the demise of GtkObject
prepare mutter for the demise of GtkObject
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2010-09-26 23:52 UTC by Matthias Clasen
Modified: 2010-09-27 17:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (4.09 KB, patch)
2010-09-26 23:52 UTC, Matthias Clasen 		none Details | Review
ifdef-enhanced patch (5.09 KB, patch)
2010-09-27 17:51 UTC, Matthias Clasen 		accepted-commit_now Details | Review

Description Matthias Clasen 2010-09-26 23:52:38 UTC 
Created attachment 171154 [details] [review]
patch

Here is a patch that makes mutter work with GTK3 after the destroy signal has been moved to GtkWidget, and GtkObject is gone.

I don't know what the current story on gtk 2.x compatibility is. If mutter needs to continue working with gtk 2.x, we need to add some ifdefs
Comment 1 Matthias Clasen 2010-09-27 17:51:55 UTC 
Created attachment 171225 [details] [review]
ifdef-enhanced patch
Comment 2 Owen Taylor 2010-09-27 17:55:54 UTC 
Review of attachment 171225 [details] [review]:

Looks good.

(it's actually possible to have signals on non-GObject types, so not casting the argument to g_signal_connect() at all and letting g_signal_connect() take it the void * may be considered most correct. On the other hand, some people may choose to act if signals on non-GObject types don't exist :-)
Comment 3 Matthias Clasen 2010-09-27 17:59:33 UTC 
t