After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 628789 - [PATCH] Add videomaxrate filter to prevent hi cpu usage.
[PATCH] Add videomaxrate filter to prevent hi cpu usage.
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: VoIP
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2010-09-04 19:45 UTC by Oleksij Rempel
Modified: 2010-09-13 21:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch v1 (2.39 KB, patch)
2010-09-04 19:45 UTC, Oleksij Rempel
needs-work Details | Review

Description Oleksij Rempel 2010-09-04 19:45:46 UTC
Created attachment 169497 [details] [review]
patch v1

This patch add videomaxrate filter to reduce maximal frame rate
to 15fps. In most situation webcam will produce about 10fps, with a lot of
light it can even get 30fps. This will be killer on slow CPU like Athom.

I set videomaxrate befor all other plugins, so thay get reduced frame rate too.

Attention: videomaxrate depend on gst-plugins-bad
Comment 1 Frederic Peters 2010-09-04 19:54:38 UTC
Thanks; what happens when the filter is not available? If this causes a failure, would it be possible to have this filter applied only when available? (same for bug 628786)
Comment 2 Olivier Crête 2010-09-06 08:07:30 UTC
Review of attachment 169497 [details] [review]:

I agree with fredp, it's probably better to check if videomaxrate is available for now. There is a possibility that we'll merge videomaxrate into videorate at some point anyway. And my comments from bug #628786 apply here also.
Comment 3 Olivier Crête 2010-09-06 08:07:32 UTC
Review of attachment 169497 [details] [review]:

I agree with fredp, it's probably better to check if videomaxrate is available for now. There is a possibility that we'll merge videomaxrate into videorate at some point anyway. And my comments from bug #628786 apply here also.
Comment 4 Oleksij Rempel 2010-09-13 21:19:45 UTC
This was fixed with patch from bug 628786