As far as I can tell, the crash isn't necessarily due to g-s-d, but the 'expected range' issue in ListView.  Could be an issue that only manifests when gsd isn't running.

*** Bug 661824 has been marked as a duplicate of this bug. ***

*** Bug 659433 has been marked as a duplicate of this bug. ***

*** Bug 662546 has been marked as a duplicate of this bug. ***

*** Bug 660384 has been marked as a duplicate of this bug. ***

*** Bug 661112 has been marked as a duplicate of this bug. ***

I am experiencing this problem but gnome-settings daemon IS running. I am however running XMonad and I did not experience this problem before I switched to XMonad. Could this be related to how XMonad sets the size of windows when they are created?

I think this is the case because if I setup XMonad to start Banshe in float mode (so it is not forced to a specific size) then it starts fine. Also once it is started I can push the window back into XMonad's normal layout (there by forcing it to a specific size).

Is Banshee trying to resize widgets based on the size it requested instead of the size it was actually allocated?

For those who need an XMonad work around:
 title =? "Banshee Media Player"        --> doFloat
in your manageHooks. I have this in my xmonad.hs:

main = xmonad $ defaultConfig
        { manageHook = myManageHook
        } 

myManageHook = composeAll
    [ className =? "MPlayer"        --> doFloat
    , className =? "Gimp"           --> doFloat
    , title =? "Banshee Media Player"        --> doFloat
    , resource  =? "desktop_window" --> doIgnore
    , resource  =? "kdesktop"       --> doIgnore ]

This also effect Version 2.2 of Banshee. Maybe the tag should be updated.

Created attachment 199796 [details] [review]
Debug patch

Can somebody apply this patch to their Hyena codebase and run banshee with it? (And post the result log here afterwards)

It will probably give us enough info to figure out what is happening.

Created attachment 199883 [details]
A side by side diff showing the differences between the floating and tiled debug output

This is the output of Banshee when run under XMonad with the debug patch applied. The left pane is the floating version (where it worked before). The right pane is the tiled version (where it used to crash). It now starts correctly in either mode. 

Overall it looks like the first group of OnSizeAllocated's is the same in both cases but the second group generates some real differences including a negative number. Also OnSizeAllocated seems to be called one less times in the tiled mode.

I just thought of something that might be relevant. XMonad does not draw window decorations (other than a 1 pixel border). Is Hyena assuming that there is a title bar on the window? Looking at MoveResize() it looks like HeaderHeight is being used to compute the rectanges. It seems that HeaderHeight is computed assuming that a title bar that is at least the height of "W" is being used. This is not the case on XMonad most of the time.

The full output for the tiled version is:

[Info  20:33:43.579] Running Banshee 2.2.0: [Ubuntu 11.10 (linux-gnu, x86_64) @ 2011-10-24 20:26:34 PDT]
__ListView::OnSizeAllocated0(416:275:180:44:44:460)
__ListView::OnSizeAllocated1(0:0:0:0:44:460)
__ListView::OnSizeAllocated3(406:265:185:49:44:460)
__ListView::OnSizeAllocated0(381:275:180:465:465:846)
__ListView::OnSizeAllocated1(0:0:0:0:465:846)
__ListView::OnSizeAllocated3(371:265:185:470:465:846)
__ListView::OnSizeAllocated0(802:855:460:44:44:846)
__ListView::OnSizeAllocated1(0:0:0:0:44:846)
__ListView::OnSizeAllocated3(792:845:465:49:44:846)
[Warn  20:33:44.634] Caught an exception - System.ApplicationException: No support GNOME Settings Daemon could be reached. (in `Banshee.MultimediaKeys')
  at Banshee.MultimediaKeys.MultimediaKeysService.Banshee.ServiceStack.IExtensionService.Initialize () [0x00000] in <filename unknown>:0 
  at Banshee.ServiceStack.ServiceManager.StartExtension (Mono.Addins.TypeExtensionNode node) [0x00000] in <filename unknown>:0 
[Warn  20:33:44.635] Extension `Banshee.MultimediaKeys.MultimediaKeysService' not started: No support GNOME Settings Daemon could be reached.
[Info  20:33:44.644] Updating web proxy from GConf
[Info  20:33:44.725] Netbook extension initialized with hidden panel
[Warn  20:33:44.782] Caught an exception - System.ApplicationException: No support GNOME Settings Daemon could be reached. (in `Banshee.MultimediaKeys')
  at Banshee.MultimediaKeys.MultimediaKeysService.Banshee.ServiceStack.IExtensionService.Initialize () [0x00000] in <filename unknown>:0 
  at Banshee.ServiceStack.ServiceManager.StartExtension (Mono.Addins.TypeExtensionNode node) [0x00000] in <filename unknown>:0 
[Warn  20:33:44.782] Extension `Banshee.MultimediaKeys.MultimediaKeysService' not started: No support GNOME Settings Daemon could be reached.
[Info  20:33:44.783] All services are started 0.935155
** (Banshee:4200): DEBUG: SyncDaemon already running, initializing SyncdaemonDaemon object

(Banshee:4200): libsoup-WARNING **: No feature manager for feature of type 'U1RequestChrome'
[Info  20:33:45.658] AmazonMP3 store redirect URL: https://one.ubuntu.com/music/store/amz/
__ListView::OnSizeAllocated0(416:275:180:71:71:487)
__ListView::OnSizeAllocated1(406:265:185:49:71:487)
__ListView::OnSizeAllocated2(406:265:185:49:71:487)
__ListView::OnSizeAllocated3(406:265:185:76:71:487)
__ListView::OnSizeAllocated0(1:275:180:492:492:493)
__ListView::OnSizeAllocated1(371:265:185:470:492:493)
__ListView::OnSizeAllocated2(371:265:185:470:492:493)
__ListView::OnSizeAllocated3(-9:265:185:497:492:493)
__ListView::OnSizeAllocated0(421:630:460:71:71:492)
__ListView::OnSizeAllocated1(765:845:465:76:71:492)
__ListView::OnSizeAllocated2(765:845:465:76:71:492)
__ListView::OnSizeAllocated3(384:620:465:103:71:492)
[Info  20:33:46.221] nereid Client Started
[Info  20:33:46.370] GStreamer version 0.10.35.0, gapless: True, replaygain: True
[Info  20:33:46.449] AppleDeviceSource is ignoring unmounted volume 8.1 GB Filesystem
[Info  20:33:46.458] AppleDeviceSource is ignoring unmounted volume System Reserved
[Info  20:33:46.460] AppleDeviceSource is ignoring unmounted volume 100 GB Filesystem


I hope that helps. Thanks for the debug patch!!

(In reply to comment #10)
> ...

Thanks for testing the patch! I guess the culprit is that negative value (-9) as you already mention.

Please also note my debug patch has a typo (it keeps printing allocation's values instead of list_rendering_alloc's for .Top and .Bottom properties...).

I hope to have some time in the following days to figure out why/how that negative value is generated.


> It now starts correctly in either mode.

I guess that's because I also replaced the ArgumentException in the setter with a value overriding to 0. Anyway it's not the correct fix so we need to figure out the appropiate patch.

Just a heads up, I've uploaded a modified version of your patch to oneiric-proposed as a stop-gap measure (it's post-release, after all, so it would be nice to have Banshee stop crashing), so people using 2.2.1 in Oneiric will probably stop seeing this bug.

According to https://bugs.launchpad.net/ubuntu/+source/banshee/+bug/873787/comments/15, this bug can be reproduced by setting /apps/banshee-1/interface/panes/albumartist/browser/top/position to 0 and then starting Banshee.

https://launchpadlibrarian.net/86524861/banshee%20error is another log of the crash which apparently happens when pressing the resize button in the context pane.

(In reply to comment #13)
> According to
> https://bugs.launchpad.net/ubuntu/+source/banshee/+bug/873787/comments/15, this
> bug can be reproduced by setting
> /apps/banshee-1/interface/panes/albumartist/browser/top/position to 0 and then
> starting Banshee.

I cannot reproduce the bug using this approach :(

Created attachment 224178 [details] [review]
Patch

In a similar way we have done in bug 683359, I am proposing this partial fix (that solves at least the crashing, as tested by Arthur).

Sorry for the delay Arthur.

Comment on attachment 224178 [details] [review]
Patch

Thanks for the patch, please commit.

Comment on attachment 224178 [details] [review]
Patch

Pushed: http://git.gnome.org/browse/hyena/commit/?id=79c651265c82b1e7249649289222a681c593863e

This problem has been fixed in the development version. The fix will be available in the next major software release (2.5.1). Thank you for your bug report.

(Thanks for the review)