After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621530 - filesink ignores sync=true
filesink ignores sync=true
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.10.28
Other Linux
: Normal normal
: 0.10.30
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-06-14 11:13 UTC by jon.orebro
Modified: 2010-06-16 11:06 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description jon.orebro 2010-06-14 11:13:13 UTC
this processes the file in realtime (I mean it takes as long to process it as the video is long, which is what I want):

 gst-launch-0.10 filesrc location=test1.avi ! decodebin2 ! fakesink sync=true

this too:

 gst-launch-0.10 filesrc location=test1.avi ! decodebin2 ! identity sync=true ! filesink location=/dev/null

but this doesnt:

 gst-launch-0.10 filesrc location=test1.avi ! decodebin2 ! filesink location=/dev/null sync=true

so filesink seems to ignore the sync property.
Comment 1 Wim Taymans 2010-06-14 14:52:46 UTC
commit 2ced5a5d6595b8312c626cce39985f81f3fd4883
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Mon Jun 14 16:50:41 2010 +0200

    filesink: use the default get_times function
    
    Use the default get_times function of basesink so that we honour the sync
    property instead of never synchronizing to the clock.
    
    Fixes #621530
Comment 2 jon.orebro 2010-06-15 02:01:23 UTC
nice.
i just found that fdsink seems to have the same problem.
Comment 3 Wim Taymans 2010-06-16 11:06:01 UTC
commit bd9cd476339aa0f873e5b59a7a1c3c2e9e3f8b8f
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Wed Jun 16 13:00:30 2010 +0200

    fdsink: make sync property work correctly
    
    Don't override the default get_times vmethod so that we can use the sync
    property.
    Set the default sync property to FALSE. It used to be set to TRUE but because
    the get_times was NULL, it always behaved like FALSE.
    
    Fixes #621530