After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619898 - convert user settings from gconf to dconf
convert user settings from gconf to dconf
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: general
2.29.x
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2010-05-28 03:26 UTC by Matthias Clasen
Modified: 2010-08-05 13:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (3.81 KB, patch)
2010-05-28 03:26 UTC, Matthias Clasen
accepted-commit_now Details | Review
patch (3.79 KB, patch)
2010-07-28 12:21 UTC, Tomas Bzatek
committed Details | Review

Description Matthias Clasen 2010-05-28 03:26:29 UTC
Created attachment 162166 [details] [review]
patch

This can be mostly done using the gsettings-data-convert tool thats shipped with GConf. The following patch installs a conversion file that gets used by that tool.

Note that I've commented out the print-line-number key for now, since gsettings-data-convert can't yet do integer type conversions like int->uint like that.
Comment 1 Ignacio Casal Quinteiro (nacho) 2010-05-28 03:35:34 UTC
Review of attachment 162166 [details] [review]:

Looks good, feel free to commit.
Comment 2 Tomas Bzatek 2010-07-28 12:21:49 UTC
Created attachment 166699 [details] [review]
patch

Modified patch fixing the org.gnome.gedit-preferences.ui and side-pane-visible typos. Also checked against gedit git master.

(In reply to comment #0)
> Note that I've commented out the print-line-number key for now, since
> gsettings-data-convert can't yet do integer type conversions like int->uint
> like that.
There are more than just the "print-line-numbers" key with 'u' type:
  auto-save-interval, undo-actions-limit, max-undo-actions, tabs-size, right-margin-position, max-recents

I've commented them all out since they tend to throw an assertion:

(gsettings-data-convert:21406): GLib-GIO-CRITICAL **: g_settings_set_value: assertion `g_settings_range_check (&info, value)' failed

Furthemore, schema description for the "max-undo-actions" key mentions usage of "-1" while being of an unsigned int type.

Also, keys of custom enum types should define aliases for mapping during conversion.
Comment 3 Tomas Bzatek 2010-08-05 13:17:24 UTC
Committed to master. Please see bug 626106 for the remaining data mapping issues.

commit c8e857ed1f711aeba672ae3cdaca4b523325e68d
Author: Tomas Bzatek <tbzatek@redhat.com>
Date:   Thu Aug 5 15:12:25 2010 +0200

    Add GSettings migration file
    
    See bug 619898 for details.