GNOME Bugzilla – Bug 618039
port gconf to GDBus
Last modified: 2018-08-17 13:54:36 UTC
Currently libgconf-2 links to libdbus and libdbus-glib which are GPL2-only, making libgconf-2 effectively GPL2-only too. Porting to GDBus will make it LGPL2+ again.
Created attachment 160528 [details] [review] Use GDBus for libgconf-2 Port libgconf-2 to GDBus, removing libdbus and libdbus-glib. libgconf-2 is now LGPL-2+ again! Note that gconfd-2 itself still uses libdbus[-glib]. Bug #618039.
I ported all of gconf to gdbus; it's on the "gdbus" branch in git.
Review of attachment 160528 [details] [review]: Looks good, please commit with the small change below. ::: gconf/gconf-internals.c @@ +2460,3 @@ + "GetIOR", + g_variant_new ("()"), + start_if_not_found ? 0 : G_DBUS_INVOKE_METHOD_FLAGS_NO_AUTO_START, Can you use G_DBUS_CALL_FLAGS_NONE instead of 0?
(In reply to comment #2) > I ported all of gconf to gdbus; it's on the "gdbus" branch in git. Is there another bug for this? I can try to review the branch in a few days.
(In reply to comment #3) > Review of attachment 160528 [details] [review]: > > Looks good, please commit with the small change below. > > ::: gconf/gconf-internals.c > @@ +2460,3 @@ > + "GetIOR", > + g_variant_new ("()"), > + start_if_not_found ? 0 : > G_DBUS_INVOKE_METHOD_FLAGS_NO_AUTO_START, > > Can you use G_DBUS_CALL_FLAGS_NONE instead of 0? Sure, I'll fix that. (In reply to comment #4) > (In reply to comment #2) > > I ported all of gconf to gdbus; it's on the "gdbus" branch in git. > > Is there another bug for this? I can try to review the branch in a few days. No, it's _this_ bug :) Note that this is *not* about the gconf-dbus branch/fork (which ports all of gconf from orbit to dbus), but only about replacing the existing dbus[-glib] code in gconf _master_ (the gconfd server, and the gconf-defaults mechanism) with equivalent gdbus code.
Comment on attachment 160528 [details] [review] Use GDBus for libgconf-2 Pushed the first patch to master with the change requested, and rebased the gdbus branch on top of master.
Just wanted to mention that the rest of the patches on the "gdbus" branch in git isn't that urgent to review/commit, since gconfd and gconf-defaults are OOP which means I don't care if they link to libdbus (OOP makes the licence issue irrelevant). So if you're busy, this could wait until 2.33. :)
Any news about this?
Seems this was fixed in 2.31.91?
Sorry, my mistake, only the libgconf-2 part was ported. Sorry for the noise. (But the remaining patches will need to be rebased and extended, now that the branch to use D-Bus instead of CORBA has been merged.)
Fixed in gconf 3.1.3. See http://mail.gnome.org/archives/desktop-devel-list/2011-June/msg00087.html and follow-ups.
*NOT* fixed. Note that this is about porting to GDbus, not dbus-glib.
Sorry, my fault.
GConf has been deprecated since 2011. GConf is not under active development anymore. Its codebase has been archived: https://gitlab.gnome.org/Archive/gconf/commits/master dconf and gsettings are its successors. See https://developer.gnome.org/gio/stable/ch34.html and https://developer.gnome.org/GSettings/ for porting info. Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Feel free to open a task in GNOME Gitlab if the issue described in this task still applies to a recent + supported version of dconf/gsettings. Thanks!