After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616923 - camerabin: remove photography interface implementation
camerabin: remove photography interface implementation
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.21
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-04-27 08:13 UTC by Lasse Laukkanen
Modified: 2010-09-21 00:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-camerabin-remove-photography-interface-implementatio.patch (33.00 KB, patch)
2010-04-27 08:13 UTC, Lasse Laukkanen
none Details | Review
0002-camerabin-monitor-scene-mode-property-from-video-sou.patch (4.69 KB, patch)
2010-04-27 08:14 UTC, Lasse Laukkanen
none Details | Review
0003-tests-camerabin-remove-photoiface-property-settings-.patch (10.63 KB, patch)
2010-04-27 08:15 UTC, Lasse Laukkanen
none Details | Review
0004-examples-camerabin-use-photoiface-properties-through.patch (3.66 KB, patch)
2010-04-27 08:15 UTC, Lasse Laukkanen
none Details | Review
0005-examples-camerabin-use-photoiface-through-video-sour.patch (5.29 KB, patch)
2010-04-27 08:15 UTC, Lasse Laukkanen
none Details | Review

Description Lasse Laukkanen 2010-04-27 08:13:49 UTC
Created attachment 159671 [details] [review]
0001-camerabin-remove-photography-interface-implementatio.patch

This set of patches removes photography implementation from camerabin.

Rationale for this change is that currently camerabin is mostly just proxying 
the photography interface properties to video-source and thus photography 
interface implementation is causing additional maintenance and implementation 
work for camerabin when changing the interface. Currently only setting scene-mode as 'night' requires special handling in camerabin to select lower framerate 
for video.

Also, supporting photography interface functionality requires special hardware 
and a video-source implementing the interface. If such hardware and video-
source are not in place then setting photography interface properties using 
camerabin do not have any effect. And vice versa, photography interface 
properties can be used directly using the video-source when support is in 
place. The used video-source can be queried from camerabin using the video-
source property.

First patch removes the photography interface implementation and notification 
signal proxy.

Second patch adds monitoring the scene-mode change for video-source to update 
the framerate.

The last three patches update camerabin unit tests and examples to use 
photography interface through video-source if available.
Comment 1 Lasse Laukkanen 2010-04-27 08:14:29 UTC
Created attachment 159672 [details] [review]
0002-camerabin-monitor-scene-mode-property-from-video-sou.patch
Comment 2 Lasse Laukkanen 2010-04-27 08:15:03 UTC
Created attachment 159673 [details] [review]
0003-tests-camerabin-remove-photoiface-property-settings-.patch
Comment 3 Lasse Laukkanen 2010-04-27 08:15:26 UTC
Created attachment 159674 [details] [review]
0004-examples-camerabin-use-photoiface-properties-through.patch
Comment 4 Lasse Laukkanen 2010-04-27 08:15:53 UTC
Created attachment 159675 [details] [review]
0005-examples-camerabin-use-photoiface-through-video-sour.patch
Comment 5 Thiago Sousa Santos 2010-06-02 02:55:33 UTC
I agree with the rationale and the patches, Stefan?
Comment 6 Stefan Sauer (gstreamer, gtkdoc dev) 2010-06-02 09:46:18 UTC
We generally lack of a strategy in gstreamer regarding bins and proxying interfaces. Anyway +1 from my side too, especially since there is
gst_bin_iterate_all_by_interface(). Maybe this can be mentioned in the camerabin docs as a additional patch.
Comment 7 Thiago Sousa Santos 2010-09-21 00:51:17 UTC
commit 30ff1ea346610a6a6b43e23188575db3c67014d5
Author: Thiago Santos <thiago.sousa.santos@collabora.co.uk>
Date:   Mon Sep 20 21:46:49 2010 -0300

    camerabin: Mention photography interface in docs
    
    Add a note to docs about getting the videosource and accessing
    its photography interface (in case it has it)
    
    Fixes #616923

commit 9bace27300ed323f4ce06b5dc9122276a1742a7e
Author: Teemu Katajisto <ext-teemu.katajisto@nokia.com>
Date:   Thu Apr 22 17:46:59 2010 +0300

    examples: camerabin: use photoiface properties through video-source
    
    Fixes #616923

commit e0dae09731c36bc0ab49ef7e40fe1f7b46f62757
Author: Teemu Katajisto <ext-teemu.katajisto@nokia.com>
Date:   Thu Apr 22 14:03:34 2010 +0300

    tests: camerabin: remove photoiface property/settings tests
    
    Fixes #616923

commit 3582a4a595b0c51f98ebd9c04206afba8dfbacec
Author: Teemu Katajisto <ext-teemu.katajisto@nokia.com>
Date:   Tue Aug 31 18:06:15 2010 -0300

    camerabin: remove photography interface implementation from camerabin
    
    Remove notify signal proxy for video-source. Application can use
    video-source directly from now on to get notified of property changes.
    Add monitoring scene-mode property change to select lowest possible
    framerate for video capture when night mode is selected.
    
    Fixes #616923