After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616438 - Properties dialog should be a sidebar
Properties dialog should be a sidebar
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
2.30.x
Other Linux
: Normal normal
: GNOME3.4
Assigned To: EOG Maintainers
EOG Maintainers
: 540686 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-04-21 21:18 UTC by Allan Day
Modified: 2012-01-24 17:38 UTC
See Also:
GNOME target: ---
GNOME version: 2.29/2.30


Attachments
screenshot of metadata in sidebar (179.38 KB, image/png)
2011-10-20 13:54 UTC, Felix Riemann
Details

Description Allan Day 2010-04-21 21:18:51 UTC
Having the properties dialog as a sidebar would offer a number of advantages over the current approach:

 * It would make the relationship between the main image view images and the properties much clearer.

 * It would also be a much more efficient use of EoG's existing functionality. The current properties dialog ends up reimplementing a large amount of EoG's functionality just to make browsing image properties possible - it has back and forward buttons and an image preview of its own (it has enough functionality to be a separate image properties viewing application in its own right!). Using a sidebar for properties would mean that the current image view and browsing interface (including the 'collection' thumbnails) could be used - which is far superior to what the current properties dialog has. A sidebar would be simpler and more elegant - fewer interface elements like the additional image preview would be required.

 * One further issue with the current properties dialog that this change would solve is the unusual way in which it updates when the image being viewed in the main window is changed. This is quite unconventional for GNOME apps (compare with Nautilus, for example) and is pretty bad, interaction wise. I'm pretty sure the HIG says something about this somewhere...

I'd suggest that the sidebar be placed on the right side of the window - to indicate that the properties are subordinate to the image being viewed. I can provide mockups if necessary.

This bug is similar to https://bugzilla.gnome.org/show_bug.cgi?id=540686 and https://bugzilla.gnome.org/show_bug.cgi?id=486364, but I think it is different enough to warrant its own report.
Comment 1 Felix Riemann 2011-10-20 13:54:16 UTC
Created attachment 199527 [details]
screenshot of metadata in sidebar

I made a test trying to follow your mockup from
https://live.gnome.org/EyeOfGnome/PlaceForNewIdeas/UIRefinements

The biggest problem so far are the large data labels that are pretty long (esp. the Flash label) and hard to read.
Comment 2 Felix Riemann 2011-10-20 17:48:45 UTC
Setting milestone. Will try to finish it this cycle.
Comment 3 Felix Riemann 2011-12-19 17:26:03 UTC
It's not perfect yet, but maybe we can gather some feedback already.

commit 7ac112f2dde1dcf76b5693d3036dd2d2625a193f
Author: Felix Riemann <>
Date:   Mon Dec 19 18:20:30 2011 +0100

    Make Exif/XMP summaries available as sidebar
    
    Makes the data from the properties dialog available as a sidebar.
    A button opens the details tab in the properties dialog.
    This is graphically still a bit roughg.
    Committing it in hopes to get some early feedback.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=616438

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 4 Allan Day 2011-12-19 17:58:23 UTC
That's great! Thanks Felix. :)
Comment 5 Felix Riemann 2011-12-19 21:49:53 UTC
*** Bug 540686 has been marked as a duplicate of this bug. ***
Comment 6 Claudio Saavedra 2011-12-20 00:17:55 UTC
I missed this discussion entirely. My bad.

I feel that somehow we're going back to the cluttered properties sidepan we used to have before 2.14 (or something like that). I don't particularly like it.

I'd seriously vouch for having a more reduced set of properties displayed and probably even hiding the properties whose values are empty.

Also, I don't understand how the mockups by Allan are connected with these here https://live.gnome.org/Design/Apps/Photos . It would be good to follow one set of mockups only, for consistency.
Comment 7 Felix Riemann 2011-12-30 11:18:13 UTC
(In reply to comment #6)
> I missed this discussion entirely. My bad.

No problem.

> I feel that somehow we're going back to the cluttered properties sidepan we
> used to have before 2.14 (or something like that). I don't particularly like
> it.
> 
> I'd seriously vouch for having a more reduced set of properties displayed and
> probably even hiding the properties whose values are empty.

The old sidebar was cluttered IMHO because it used the listview that we now have in the properties dialog's details panel. Showing a reduced dataset should help a bit here. I guess we can try to implement the removal of empty values. The biggest problem I have so far with it is the restricted horizontal space we have in the sidebar, ellipsizing many entries..

> Also, I don't understand how the mockups by Allan are connected with these here
> https://live.gnome.org/Design/Apps/Photos . It would be good to follow one set
> of mockups only, for consistency.

For now I guess, it's two applications. From how I understood the short discussion about Photos, we are going to make most of eog available as a shared library again, which both Photos and eog can use. This also makes sense IMHO because Photos focuses quite a bit on the collection management part which eog tries to go out of the way. Yet, both apps display images at the end, so there should be room for sharing code.
Comment 8 John Stowers 2012-01-20 22:03:21 UTC
> 
> For now I guess, it's two applications. From how I understood the short
> discussion about Photos, we are going to make most of eog available as a shared
> library again, which both Photos and eog can use. This also makes sense IMHO
> because Photos focuses quite a bit on the collection management part which eog
> tries to go out of the way. Yet, both apps display images at the end, so there
> should be room for sharing code.

I was actually looking into hacking on Photos, and was wondering if EOG or GtkImageView was suggested as the base. Is this discussion going on in public anywhere?
Comment 9 William Jon McCann 2012-01-24 17:38:05 UTC
Hi John.

It would be great if you wanted to help with Photos! We can discuss it on #gnome-design and #gnome-os. As far as the base - I'll leave it to you experts :)