After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616172 - Return NULL from imapx_find_commad_tag when not found
Return NULL from imapx_find_commad_tag when not found
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.30.x (obsolete)
Other All
: Normal critical
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
evolution[imapx]
Depends on:
Blocks:
 
 
Reported: 2010-04-19 13:11 UTC by Pascal Terjan
Modified: 2010-09-30 11:40 UTC
See Also:
GNOME target: ---
GNOME version: 2.29/2.30


Attachments
This patch fixes the crash (see comment below) (525 bytes, patch)
2010-08-11 20:28 UTC, Julien Ducourthial
committed Details | Review

Description Pascal Terjan 2010-04-19 13:11:00 UTC
What were you doing when the application crashed?
Nothing

evolution was running in background


Distribution: Mandriva Linux release 2010.1 (Cooker) for i586
Gnome Release: 2.30.0 2010-03-31 (Mandriva)
BugBuddy Version: 2.30.0

System: Linux 2.6.33.2-desktop-1mnb #1 SMP Tue Apr 6 01:37:12 UTC 2010 i686
X Vendor: The X.Org Foundation
X Vendor Release: 10706000
Selinux: No
Accessibility: Disabled
GTK+ Theme: M
Icon Theme: Tango-Blue-Materia
GTK+ Modules: canberra-gtk-module, pk-gtk-module, gnomebreakpad

Memory status: size: 384028672 vsize: 384028672 resident: 76910592 share: 24342528 rss: 76910592 rss_rlim: 18446744073709551615
CPU usage: start_time: 1271680202 rtime: 1412 utime: 1328 stime: 84 cutime:1 cstime: 0 timeout: 0 it_real_value: 0 frequency: 100

Backtrace was generated from '/usr/bin/evolution'

[?1034h[Thread debugging using libthread_db enabled]
[New Thread 0xa50feb70 (LWP 28067)]
[New Thread 0xaf3feb70 (LWP 28066)]
[New Thread 0xa38fbb70 (LWP 28062)]
[New Thread 0xa30fab70 (LWP 27722)]
[New Thread 0xa40fcb70 (LWP 27706)]
[New Thread 0xae3fcb70 (LWP 27604)]
[New Thread 0xaa2a9b70 (LWP 27081)]
[New Thread 0xa6cffb70 (LWP 27080)]
[New Thread 0xabaacb70 (LWP 27075)]
[New Thread 0xa91f6b70 (LWP 27071)]
[New Thread 0xa99f7b70 (LWP 27070)]
[New Thread 0xacbf9b70 (LWP 27062)]
[New Thread 0xadbfbb70 (LWP 27061)]
[New Thread 0xad3fab70 (LWP 27060)]
[New Thread 0xaebfdb70 (LWP 27057)]
[New Thread 0xafbffb70 (LWP 27055)]
[New Thread 0xb05ffb70 (LWP 27054)]
[New Thread 0xb0fffb70 (LWP 27053)]
[New Thread 0xb196eb70 (LWP 27052)]
0xffffe424 in __kernel_vsyscall ()

Thread 4 (Thread 0xa38fbb70 (LWP 28062))

  • #0 __kernel_vsyscall
  • #1 __lll_lock_wait
    at ../nptl/sysdeps/unix/sysv/linux/i386/i486/lowlevellock.S line 142
  • #2 _L_lock_658
    from /lib/i686/libpthread.so.0
  • #3 __pthread_mutex_lock
    at pthread_mutex_lock.c line 61
  • #4 <signal handler called>
  • #5 camel_dlist_remove
    at camel-list-utils.c line 95
  • #6 imapx_completion
    at camel-imapx-server.c line 1590
  • #7 imapx_step
    at camel-imapx-server.c line 1638
  • #8 imapx_command_run
    at camel-imapx-server.c line 1658
  • #9 imapx_reconnect
    at camel-imapx-server.c line 2344
  • #10 camel_imapx_server_connect
    at camel-imapx-server.c line 3880
  • #11 imapx_sync
    at camel-imapx-folder.c line 163
  • #12 camel_folder_sync
    at camel-folder.c line 328
  • #13 refresh_folders_exec
    at mail-send-recv.c line 888
  • #14 mail_msg_proxy
    at mail-mt.c line 471
  • #15 g_thread_pool_thread_proxy
    at gthreadpool.c line 315
  • #16 g_thread_create_proxy
    at gthread.c line 1893
  • #17 start_thread
    at pthread_create.c line 297
  • #18 clone
    at ../sysdeps/unix/sysv/linux/i386/clone.S line 130

	Inferior 1 [process 27051] will be detached.

Quit anyway? (y or n) [answered Y; input not from terminal]


----------- .xsession-errors (54 sec old) ---------------------
(galeon:23235): GLib-GObject-WARNING **: invalid (NULL) pointer instance
(galeon:23235): GLib-GObject-CRITICAL **: g_signal_handlers_disconnect_matched: assertion `G_TYPE_CHECK_INSTANCE (instance)' failed
(galeon:23235): GLib-GObject-WARNING **: invalid (NULL) pointer instance
(galeon:23235): GLib-GObject-CRITICAL **: g_signal_handlers_disconnect_matched: assertion `G_TYPE_CHECK_INSTANCE (instance)' failed
(gnome-settings-daemon:2039): GVFS-RemoteVolumeMonitor-WARNING **: Owner :1.304 of volume monitor org.gtk.Private.GduVolumeMonitor disconnected from the bus; removing drives/volumes/mounts
(galeon:23235): GVFS-RemoteVolumeMonitor-WARNING **: Owner :1.304 of volume monitor org.gtk.Private.GduVolumeMonitor disconnected from the bus; removing drives/volumes/mounts
(nautilus:3099): GVFS-RemoteVolumeMonitor-WARNING **: Owner :1.304 of volume monitor org.gtk.Private.GduVolumeMonitor disconnected from the bus; removing drives/volumes/mounts
(galeon:23235): GLib-GObject-CRITICAL **: g_object_ref: assertion `G_IS_OBJECT (object)' failed
--------------------------------------------------
Comment 1 Pascal Terjan 2010-04-20 08:26:06 UTC
I have got this crash several times a day over last few days so I can test potential fixes.
Comment 2 Julien Ducourthial 2010-08-11 20:23:43 UTC
I've been experiencing crashes on a near to daily basis :
  • #0 camel_dlist_remove
    at camel-list-utils.c line 95
  • #1 imapx_completion
    at camel-imapx-server.c line 1598
  • #2 imapx_step
    at camel-imapx-server.c line 1646
  • #3 imapx_command_run
    at camel-imapx-server.c line 1666
  • #4 imapx_reconnect
    at camel-imapx-server.c line 2529
  • #5 camel_imapx_server_connect
    at camel-imapx-server.c line 4112

Comment 3 Julien Ducourthial 2010-08-11 20:28:39 UTC
Created attachment 167665 [details] [review]
This patch fixes the crash (see comment below)

The patch corrects the problem in imapx_find_commad_tag :
before : this function NEVER returns NULL, instead it returns the tail of the
active queue if the tag is not found => 
  the error is not detected by imapx_completion which then calls
camel_dllist_remove causing the crash.

after : the function returns NULL if tag is not found. 

(patch also sent to fedora)
Comment 4 Milan Crha 2010-09-30 11:31:17 UTC
Comment on attachment 167665 [details] [review]
This patch fixes the crash (see comment below)

Good catch. I'm confirming for committing.
Comment 5 Milan Crha 2010-09-30 11:40:29 UTC
Created commit df294ca in eds master (2.33.1+)
Created commit 6cabe11 in eds gnome-2-32 (2.32.1+)