After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 615362 - Please provide full content zoom support in epiphany
Please provide full content zoom support in epiphany
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Backend
2.30.x
Other Linux
: Normal normal
: ---
Assigned To: Xan Lopez
Epiphany Maintainers
: 620561 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-04-10 15:31 UTC by Hicham HAOUARI
Modified: 2010-11-07 20:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
epiphany-2.30.0-full-zoom.patch (346 bytes, patch)
2010-04-12 20:53 UTC, Hicham HAOUARI
needs-work Details | Review

Description Hicham HAOUARI 2010-04-10 15:31:50 UTC
Full content zoom is supported in all major browsers nowadays, it is supported by webkit too. Actually, it is a one line patch.

Even though i think it should default, at least provide an option to turn it on.

I would be happy to help with that.
Comment 1 Gustavo Noronha (kov) 2010-04-12 13:35:57 UTC
I second this request.
Comment 2 Reinout van Schouwen 2010-04-12 14:06:10 UTC
I vaguely remember a discussion about this issue in the past, where the conclusion was that it was better to leave full content magnification to composited environments because it would be less ugly. Don't know if that is still the case.
Comment 3 Hicham HAOUARI 2010-04-12 20:53:01 UTC
(In reply to comment #2)
> I vaguely remember a discussion about this issue in the past, where the
> conclusion was that it was better to leave full content magnification to
> composited environments because it would be less ugly. Don't know if that is
> still the case.

I don't think full-zoom support in browsers is the same as content magnification is composited environments. And that decision is a plain removal of features already provided by the backend (well, gecko didn't start providing it until 1.9 ).

Here is the quick patch I use ( and also ugly ) to have full content zoom in epiphany.
Comment 4 Hicham HAOUARI 2010-04-12 20:53:58 UTC
Created attachment 158534 [details] [review]
epiphany-2.30.0-full-zoom.patch
Comment 5 Gustavo Noronha (kov) 2010-04-26 12:03:59 UTC
Yeah, this has nothing to do with magnification. You don't want to look elsewhere for the content, and you want to be able to interact with the magnified content just like you do with the normal one. Along with image auto-resizing I think it's a mistake to disable this functionality.
Comment 6 Gustavo Noronha (kov) 2010-04-26 12:04:55 UTC
Review of attachment 158534 [details] [review]:

This is not what is needed, though. Supporting text-only zoom keeps being important, and this would be better left for a configuration, with a checkbox item in a menu, for instance.
Comment 7 Hicham HAOUARI 2010-04-26 12:10:23 UTC
(In reply to comment #6)
> Review of attachment 158534 [details] [review]:
> 
> This is not what is needed, though. Supporting text-only zoom keeps being
> important, and this would be better left for a configuration, with a checkbox
> item in a menu, for instance.

I was on my way to do that, but one of the main epiphany developers is against providing an option to toggle full-zoom on and off. He either want it to be default, or not provided at all.
Comment 8 Daniel Michalik 2010-05-04 12:42:23 UTC
I'd like to second the request. I have a lot of pages with fixed width where I find the text size too small. If I currently zoom in the text size increases but the width stays the same -> page gets unreadable. 

I also understand why people would want "text only" zoom so I'd reallly appreciate to find an option for that. Probably a gconf key as a kind of compromise between having the option and not wasting space in preferences?
Comment 9 Hicham HAOUARI 2010-05-04 18:44:17 UTC
(In reply to comment #8)
> I'd like to second the request. I have a lot of pages with fixed width where I
> find the text size too small. If I currently zoom in the text size increases
> but the width stays the same -> page gets unreadable. 
> 
> I also understand why people would want "text only" zoom so I'd reallly
> appreciate to find an option for that. Probably a gconf key as a kind of
> compromise between having the option and not wasting space in preferences?

You should convince the developers
Comment 10 gan lu 2010-05-28 09:50:56 UTC
With a high definition display saying "1600*1200 on a 15 inch screen", you will immediately notice how important the full zoom is. Text-only-zoom makes a page displaying awfully ugly, almost drive people away from reading.
Comment 11 gan lu 2010-06-06 03:51:59 UTC
This bug seems a reduplication or similar one of the old one:
https://bugzilla.gnome.org/show_bug.cgi?id=161650
Comment 12 Frederic Peters 2010-06-06 06:52:53 UTC
*** Bug 620561 has been marked as a duplicate of this bug. ***
Comment 13 James 2010-06-11 14:39:19 UTC
I think it's valuable to have access to both types of zooming.
Perhaps (as to avoid clutterting the ui) regular clicking on the +/- buttons or keypresses could zoom *everything*, however using a modifier such as <CTRL> + click or buttons would cause text to zoom.
Hope this is a useful idea that everyone would like.

Additionally as a bonus, i'm not sure how the gtk hackery would work, but if possible, perhaps the gtk menus and buttons could change to reflect the difference when the CTRL key is held down.

Thanks for epiphany!
Comment 14 Albert Gasset 2010-08-29 19:43:17 UTC
I've created a little extension that enables full content zoom:
http://gitorious.org/epiphany-fullzoom (copy the files in the repository to ~/.gnome2/epiphany/extensions/)

Maybe it could be included in epiphany-extensions as a fix for this bug.
Comment 15 gan lu 2010-08-30 05:04:56 UTC
I downloaded the two files, and put the place you mentioned, but it doesn't work.
[ganlu@myhost ~]$ ls .gnome2/epiphany/extensions/
full-zoom.ephy-extension  full-zoom.js
Comment 16 Hicham HAOUARI 2010-08-30 05:09:10 UTC
This is just ridiculous, which browser still doesn't do full page zoom by default ?

I don't think it is wise to create a plugin for such a basic functionality. Just let it be the default.
Comment 17 Albert Gasset 2010-08-30 10:08:25 UTC
I'd like full page zoom by default too. But if it isn't, with this extension at least there's a way to enable it.

The extension has to be enabled in Tools -> Extensions. I've tested it with Epiphany 2.30.
Comment 18 James 2010-08-31 20:20:19 UTC
The extension doesn't seem to work for me either.
In reply to #7, If websites were all perfect, then it would only make sense to do one kind of zooming, but since they aren't and we're relatively forced to sometimes still use them, then it's useful to do text zoom when needed, and useful for full content zoom too.
Comment 19 Daniel Weinstein 2010-10-11 20:55:02 UTC
It is absolutly absurd, not to include this functionality. EVERY other webkit browser I know of either has full page zoom as the default, or as a menu option. 

I can easily understand, using text-only zoom as the default,  but I can't at all understand limiting the browser to text-only zoom.
Comment 20 Xan Lopez 2010-11-07 20:17:43 UTC
This is the default in ephy master now (3a46327008fa129b33805cc85faa6f8dd78d1f88). Supporting both full content zoom and text zoom at runtime (which is possible) is left as an exercise for the reader.