GNOME Bugzilla – Bug 604599
Don't omit notifications for downloads
Last modified: 2009-12-29 20:29:19 UTC
Current download notifications code depends on a GtkStatusIcon being embedded in the tray, this is prone to fail in a bunch of situations and hence leave the users wondering what happened with their downloads: did they finish or what? This patch removes such dependency and also removes the timeout being used. A case can be easily triggered while testing Bug #594192, you'll see that if you take long enough to choose a destination while downloading, when you finally pick one and the GtkFileChooserDialog is closed, you won't see any kind of feedback about the completion of the download, despite it indeed was completed.
Created attachment 149745 [details] [review] Don't omit notifications for downloads If a download is finished while the GtkStatusIcon for DownloadView is not embedded the finished notification for such download is missed and user is left wondering what happened with his/her download. This makes notifications show whether there is or not a GtkStatusIcon to attach to. Bug #604599
Created attachment 150530 [details] [review] Don't omit notifications for downloads If a download is finished while the GtkStatusIcon for DownloadView is not embedded the finished notification for such download is missed and user is left wondering what happened with his/her download. This makes notifications show whether there is or not a GtkStatusIcon to attach to. Bug #604599
Review of attachment 150530 [details] [review]: Yeah, I tried to touch that code when I was reimplementing download. Hairy.
Attachment 150530 [details] pushed as fab4ce4 - Don't omit notifications for downloads