GNOME Bugzilla – Bug 603152
Use libcanberra instead of GStreamer for shutter
Last modified: 2009-11-30 22:59:31 UTC
Removes code, removing code is good!
Created attachment 148600 [details] [review] Use libcanberra instead of GStreamer for shutter
Review of attachment 148600 [details] [review]: Looks fine to me. Daniel? There is another patch in bug 546929 but this seems better, see inline comment (I just wanted to test splinter since I had no chance to do it yet ;-)) ::: src/cheese-window.c @@ +1285,3 @@ shutter_filename = audio_play_get_filename (cheese_window); + ca_gtk_play_for_widget (cheese_window->screen, 0, + CA_PROP_MEDIA_FILENAME, shutter_filename, We have another patch waiting in bugzilla that uses "camera-shutter event". I suppose this would be better since it lets us use our beloved shutter sounds, Daniel?
This could be applied, and then switched to using the camera-shutter event sound when it's actually available.
*** Bug 546929 has been marked as a duplicate of this bug. ***
i removed our files, as i even wasnt sure about the copyright of the shutter sound. the camera-shutter event sound is already available since a few months. commit b7a59578b99016a79e613f8bb69f5b5e455258bb Author: Bastien Nocera <hadess@hadess.net> Date: Fri Nov 27 15:33:54 2009 +0000 Use libcanberra instead of GStreamer for shutter ⋅⋅⋅⋅ https://bugzilla.gnome.org/show_bug.cgi?id=603152