GNOME Bugzilla – Bug 598833
Do not ship dropped evo_mail_notifier.png
Last modified: 2010-09-30 06:46:36 UTC
Hey, it seems that the evo_mail_notifier.png file is missing from the tarball, breaking the documentation: corsac@hidalgo: tar tvf evolution_2.28.0.orig.tar.gz|grep notifier -rw-r--r-- 1002/100 7986 2009-09-21 12:30 evolution-2.28.0/help/fr/figures/evo_mail_notifier.png -rw-r--r-- 1002/100 4452 2009-09-21 12:30 evolution-2.28.0/help/C/figures/evo_mail_notifier.png -rw-r--r-- 1002/100 4452 2009-09-21 12:30 evolution-2.28.0/help/eu/figures/evo_mail_notifier.png corsac@hidalgo: tar tvf evolution_2.28.1.orig.tar.gz|grep notifier -rw-r--r-- 500/500 4452 2009-10-18 04:25 evolution-2.28.1/help/eu/figures/evo_mail_notifier.png -rw-r--r-- 500/500 7986 2009-10-18 04:25 evolution-2.28.1/help/fr/figures/evo_mail_notifier.png It might not be too late to fix the tarball before the “official” release tomorrow?
Please always provide the exact error message and explain why you think that this is an issue at all. That .png file is unsed in evolution.xml.
(In reply to comment #1) > Please always provide the exact error message and explain why you think that > this is an issue at all. > That .png file is unsed in evolution.xml. Well, the build system seems to make symlinks for “missing” png, which means we end up with a symlink from C/figures/evo_mail_notifier.png to ../../C/figures/evo_mail_notifier.png which doesn't really make sense. And, by the way, I find it weird that the documentation is changed in a stable release, and not changed for every translation (fr and eu still have the file).
Ok, I saw that quite some png were dropped in these release. I guess this one should then be dropped as well. Attached patch should do that.
Created attachment 145742 [details] [review] Don't ship evo_mail_notifier.png
Thanks, patch works good, it fixed some "compiler" warnings too. Created commit b94a22e in evo master (2.31.2+)
Removed some localized versions of this image in master: http://git.gnome.org/browse/evolution/commit/?id=68aa811ea45a0b68c3d675ec9ccdaaf5159daae5 And backported it all to gnome-2-30: http://git.gnome.org/browse/evolution/commit/?h=gnome-2-30&id=1a375dd3d8a2594851a67a648952c6913fb49f74
*** Bug 607052 has been marked as a duplicate of this bug. ***