GNOME Bugzilla – Bug 596870
[PATCH] Banshee doesn't play well with notify-osd - should reuse existing notification instead of creating new ones all the time
Last modified: 2009-10-04 12:21:54 UTC
Created attachment 144396 [details] [review] Patch against git HEAD to reuse existing notification rather than creating new ones for each track change From upstream Ubuntu bug, https://bugs.launchpad.net/notify-osd/+bug/334809, Banshee should reuse existing notification rather than creating new ones each time to work better with notify-osd. Attached is a patch against git HEAD which should fix this.
There was another bug (Bug 596744) about this issue, but I'll mark it as a duplicate of this report, because this one has a working patch. Thanks for the patch, by the way; I'll start testing in just a minute.
*** Bug 596744 has been marked as a duplicate of this bug. ***
Sorry for the dup... let me know how the patch goes for you as its based on the one I made against 1.4.3 in Ubuntu (which works) but I haven't really had a chance to test this one against git...
I haven't really messed around with testing this patch too much, but it seems like it only works exactly half of the time. For example: 1. A notification pops up telling me that Track1 is now playing 2. I use a multimedia key to skip Track1, Track2 starts playing 3. The Track1 notification is immediately replaced by a notification for Track2 4. I skip Track2, causing Track3 to play 5. After Track2's notification expires, the Track3 notification pops up 6. I skip Track3, Track4 starts playing, and its notification immediately replaces the previous notification. From my testing, it seems like it alternates between immediately replacing the current notification and waiting for the current notification to expire. I'm not exactly sure that this is what's happening, so I'll keep testing.
Created attachment 144444 [details] [review] Updated patch which should work 100% of the time rather than just 50%
@Michael - have you had a chance to test the updated patch? Any chance it can get accepted into trunk?
I haven't had a chance to test the patch, and I'm going to be away from my computer until Monday. In an interesting turn of events, Bug 597099 was just opened which also has a patch addressing this issue. I'll try to flag down a developer in IRC and let them do some reviewing.
After looking at the patch in Bug 597099 I'd say (without having tested it) that it looks cleaner and may be the better solution, so no worries if you want to use that instead. Cheers.
Thanks for the patch ! I committed the patch in bug 597099, as the resulting code was cleaner. So I'm marking this bug as a duplicate. *** This bug has been marked as a duplicate of bug 597099 ***