After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 596570 - [PATCH] Convert gdm from using gnome-power-manager to gnome-session for inhibits
[PATCH] Convert gdm from using gnome-power-manager to gnome-session for inhibits
Status: RESOLVED FIXED
Product: sound-juicer
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Sound Juicer Maintainers
Sound Juicer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-28 08:36 UTC by Richard Hughes
Modified: 2009-09-28 13:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to fix the problem (2.68 KB, patch)
2009-09-28 08:36 UTC, Richard Hughes
committed Details | Review

Description Richard Hughes 2009-09-28 08:36:21 UTC
Created attachment 144159 [details] [review]
patch to fix the problem

In 2-28, gnome-power-manager removed it's inhibit interface as it had been
deprecated for 2 releases. I blogged about the new gnome-session interface
here:
http://blogs.gnome.org/hughsie/2009/01/28/inhibits-and-the-new-world-order/

I've attached a patch to convert sound-juicer to using the new interface. I've
set it to inhibit bot suspending and making the session go idle, feel free to
change this if you do not like that behaviour. I've only compile tested this,
as I've not got a machine handy with a cd-rom drive installed. This fixes a
warning whenever you run s-j on a 2-28 installation. Please review and test.
Thanks.
Comment 1 Matthias Clasen 2009-09-28 13:27:09 UTC
The patch looks good to me, please put that in our rawhide sound-juicer package.
Comment 2 Ross Burton 2009-09-28 13:36:49 UTC
Comment on attachment 144159 [details] [review]
patch to fix the problem

If it's good enough for Matthias it's good enough for me.  Please commit to master.
Comment 3 Richard Hughes 2009-09-28 13:55:38 UTC
Comment on attachment 144159 [details] [review]
patch to fix the problem

Thanks for the quick review guys.