GNOME Bugzilla – Bug 596303
Missing file fallback for Adium themes not implemented.
Last modified: 2009-09-30 14:20:08 UTC
Created attachment 143985 [details] Adium theme with only the minimum required files. If files are missing from the Adium theme, the messages types handled by those files are just thrown away. Instead, the formatting should fall back to another file such as Incoming/Content.html Particularly this causes a problem with the option Incoming/NextContent.html and Outgoing/NextContent.html. If these files are present then NextContent is handled specially (by stuffing it into the html parent object which might not exist). If they are not present then continued messages are not shown at all. This means it is not possible to make a theme which does not do special handling on continued messages.
Created attachment 143986 [details] Adium theme with all required files This still doesn't work because now NextContent.html is present, empathy attempts to stuff the content into the html parent, which does not exist.
In fact, fallback does work for some files. It fails in some conditions though, such as supplying an empty Outgoing directory. In these cases it tends to segfault. The original problem was in fact caused because fallback *does* work when sometimes it shouldn't: https://bugzilla.gnome.org/show_bug.cgi?id=596317
This branch makes the correct fallbacks, as defined there: http://trac.adium.im/wiki/CreatingMessageStyles http://git.collabora.co.uk/?p=user/xclaesse/empathy.git;a=shortlog;h=refs/heads/adium-fallback I tested the first theme you attached and it seems to work perfectly. Can you confirm?
Faillback seems to work perfectly with this patch. I cannot reproduce the crashes I was getting with an empty Outgoing directory for example.
Also note, in Adium 1.4 all html files can fallback to Resources/Content.html
Branch merged to both master and gnome-2-28