After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 590656 - use-underline should be default true for buttons
use-underline should be default true for buttons
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.17.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2009-08-03 16:57 UTC by xt.knight
Modified: 2009-08-17 07:41 UTC
See Also:
GNOME target: ---
GNOME version: 2.27/2.28


Description xt.knight 2009-08-03 16:57:23 UTC 
Please describe the problem:
Several apps have recently broken in that they should an underscore instead of an underline mnemonic/accelerator.

The Win32 API has this by default for buttons as far as I can tell, but their character is '&' (ampersand).  Since using '_' in a button is rare, we might as well enable use-underline by default.  I'm not sure if this affects all buttons.  Some other reports mentioned it only affected buttons with icons, but that's not been my experience.

Steps to reproduce:
1. Start up Users and Groups administration applet.
2. Observe that the Unlock button looks like _Unlock instead of Unlock with an underlined `U'.

Actual results:


Expected results:


Does this happen every time?


Other information:
Related launchpad report: https://bugs.launchpad.net/gst/+bug/404767
Comment 1 xt.knight 2009-08-03 16:59:08 UTC 
And yes it happens every time with the same applications on the same buttons.  But for some reason only on some buttons.  It may only be the ones that are dynamically created rather than with glade.  I don't know though.  That's just an example.  I have certainly edited a glade file to fix the issue in some apps.
Comment 2 Matthias Clasen 2009-08-03 17:17:50 UTC 
there were bugs related to _ handling in both gtk and glade. With recent versions, this should all just work.
Comment 3 xt.knight 2009-08-03 17:20:31 UTC 
Matthias: Cool.  Do you know what revision distributions should sync in order to get the updates, or what commits fixed the problem?
Comment 4 Matthias Clasen 2009-08-06 16:36:33 UTC 
git log might tell you.
Comment 5 Milan Bouchet-Valat 2009-08-16 20:09:43 UTC 
Matthias: Could you give more explanations? The bug we face [1] is that the default seems to have changed so that now mnemonics are disabled in buttons. The fix is pretty straightforward, but I'd like to be sure I need to enable mnemonics by hand before committing that fix to the gnome-system-tools. The GTK+ log history did not help... Thanks!
Comment 6 Matthias Clasen 2009-08-17 01:22:34 UTC 
The default has not changed. A bug was fixed that led to underlines being interpreted in some situations despite use-underline being FALSE.
Comment 7 Milan Bouchet-Valat 2009-08-17 07:41:02 UTC 
OK, I see. The default has always been false, and we've relied on that bug. So the right thing is changing that property.