After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 590609 - file-roller silently overwrites existing files when extracting
file-roller silently overwrites existing files when extracting
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: general
2.26.x
Other All
: Normal major
: ---
Assigned To: Paolo Bacchilega
file-roller-maint
Depends on:
Blocks:
 
 
Reported: 2009-08-03 12:23 UTC by Jakob Unterwurzacher
Modified: 2012-02-21 00:03 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26



Description Jakob Unterwurzacher 2009-08-03 12:23:15 UTC
Please describe the problem:
Extracting a file from an archive to a folder that already contains a file with the same file name overwrites the original file silently. Contents are lost.

Steps to reproduce:
1) Create a zip containing a file test.txt with some content
2) Create a file text.txt in some folder with some different content
3) Extract test.txt from the zip to this folder (drag&drop or extract button)

Actual results:
The file from step 2 is silently overwritten. Contents are lost.

Expected results:
A confirmation dialog should ask me wether i want to replace the file.

Does this happen every time?
Yes.

Other information:
Ubuntu bug: https://bugs.launchpad.net/ubuntu/+source/file-roller/+bug/152303
Comment 1 Nelson Benitez 2010-05-24 23:10:56 UTC
590609
Comment 2 Rahul 2010-08-01 13:44:45 UTC
Hi,

I have checked this behaviour in version installed with fedora 13. 
File Roller 2.30.1.1


When user do extract ==> dialog box has option "Overwrite existing files"
if you uncheck that option then it will not overwrite existing file.

but something different behaviour I experienced there... if any file with same name already exist there  and "Overwrite existing files" is unchecked then it will not exact that file in that folder.

Should it not create file with different name in that case.

like  : test.text is already there then test1.text created.

Please comment.
Comment 3 jens.timmerman 2010-09-05 19:43:17 UTC
I am using File Roller 2.31.91 (ubuntu 10.10 beta)
 and can still confirm this. File roller overwrites files whitout asking when you extract them to a directory by drag and drop. This is very dangerous imho, you can lose vital files. Expected behaviour would be to ask before overwriting. 

Importantly this is about drag and drop. There are no questions asked, the file just gets overwriten!
Comment 4 Chris Wilson 2011-01-26 18:38:39 UTC
I'm following up on this bug from the original Launchpad report. Is there any progress being made here? Has the cause of the issue been identified?
Comment 5 ayan.george 2012-01-30 16:35:27 UTC
Chris,

file-roller simply needs to check for overwrites before extracting.  I provided a proof-of-concept patch in https://bugzilla.gnome.org/show_bug.cgi?id=590609

If you have any feedback, please let me know how it can be improved.
Comment 6 Sebastien Bacher 2012-02-20 11:58:27 UTC
the previous comment should probably have mentioned https://bugzilla.gnome.org/show_bug.cgi?id=405626 as bug number
Comment 7 Paolo Bacchilega 2012-02-21 00:02:04 UTC
This feature has been implemented in the development version. It will be available in the next major software release (version 3.4.0). Thank you for your bug report.
Comment 8 Paolo Bacchilega 2012-02-21 00:03:04 UTC
This feature has been implemented in the development version. It will be available in the next major software release (version 3.4.0). Thank you for your bug report.