After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 590225 - Replace gnome_help and gnome-open calls with gtk_show_uri
Replace gnome_help and gnome-open calls with gtk_show_uri
Status: RESOLVED FIXED
Product: gnome-pilot
Classification: Other
Component: general
unspecified
Other All
: Normal critical
: ---
Assigned To: Halton Huo
gnome-pilot Maintainers
Depends on:
Blocks: 590215
 
 
Reported: 2009-07-30 07:52 UTC by Halton Huo
Modified: 2009-08-07 02:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to remove gnome-help calls for gnome-pilot (2.28 KB, patch)
2009-07-30 08:43 UTC, Halton Huo
accepted-commit_now Details | Review

Description Halton Huo 2009-07-30 07:52:20 UTC
Steps to reproduce:
The goal is to remove gnome_help and gnome-open calls with gtk_show_uri. This is sub task for http://live.gnome.org/LibgnomeMustDie and bug #590215.



Stack trace:


Other information:
Comment 1 Halton Huo 2009-07-30 08:17:04 UTC
Using gnome_help calls will cause gpilot-applet crash when clicking help. Please refer to http://defect.opensolaris.org/bz/show_bug.cgi?id=10227.
Comment 2 Halton Huo 2009-07-30 08:43:36 UTC
Created attachment 139544 [details] [review]
patch to remove gnome-help calls for gnome-pilot

This patch is verified on Ubuntu 9.10 and OpenSolaris. They have have GNOME 2.27.x installed. Please review it, if looks okay, can I commit?
Comment 3 Matt Davey 2009-07-30 14:20:08 UTC
I'll take a look as soon as I can.  Can you explain why use of gnome_help causes a crash?  I have several tasks on my plate to work on removing use of libgnome, but I would not have expected things to crash in the meantime.
Comment 4 Halton Huo 2009-07-31 02:08:37 UTC
The crash happen in libgnome code, I do not think it is valuable to go inside. 
(In reply to comment #3)
> I'll take a look as soon as I can.  Can you explain why use of gnome_help
> causes a crash?  I have several tasks on my plate to work on removing use of
> libgnome, but I would not have expected things to crash in the meantime.

Comment 5 Matt Davey 2009-08-06 20:17:19 UTC
Patch looks good.  Please commit.
Comment 6 Halton Huo 2009-08-07 02:41:23 UTC
Commit as 424f2af793cb9805817186603c1413a3838ea7f2