After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 589345 - Fedora patch for using beagle/tracker at runtime instead of compiletime
Fedora patch for using beagle/tracker at runtime instead of compiletime
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: File Search Interface
0.x.x [obsolete]
Other All
: Normal enhancement
: ---
Assigned To: Tomas Bzatek
Nautilus Maintainers
Depends on:
Blocks: 608976
 
 
Reported: 2009-07-22 10:00 UTC by Pacho Ramos
Modified: 2010-03-08 11:07 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
nautilus-2.23.5-dynamic-search.patch (12.78 KB, patch)
2009-07-22 10:15 UTC, Pacho Ramos
reviewed Details | Review
nautilus-2.28.1-dynamic-search.patch (16.43 KB, patch)
2009-10-21 13:32 UTC, Tomas Bzatek
reviewed Details | Review
nautilus-2.28.1-dynamic-search.patch (24.60 KB, patch)
2010-03-05 17:17 UTC, Tomas Bzatek
committed Details | Review

Description Pacho Ramos 2009-07-22 10:00:18 UTC
This patch is being applied in fedora since a lot of time and, also, its spec says:
# Why is this not upstream ?
Patch6:         nautilus-2.23.5-dynamic-search.patch

I have tried to search in gnome bugzilla and I have failed to find any bug related with it

Thanks for checking it
Comment 1 Pacho Ramos 2009-07-22 10:15:06 UTC
Created attachment 138977 [details] [review]
nautilus-2.23.5-dynamic-search.patch
Comment 2 A. Walton 2009-09-28 14:34:23 UTC
Comment on attachment 138977 [details] [review]
nautilus-2.23.5-dynamic-search.patch

May need to check that this still works with Jurg's Tracker 0.7 patch, but otherwise I don't see any reason not to accept this.
Comment 3 Tomas Bzatek 2009-10-21 13:32:49 UTC
Created attachment 145952 [details] [review]
nautilus-2.28.1-dynamic-search.patch

Updated patch with tracker 0.7 support, incl. more code cleanup. I've removed compile time dependencies completely, libraries load in order: beagle first, tracker as a second if beagle not available, falling back to classic search if neither is available.
Comment 4 Tomas Bzatek 2009-10-21 13:35:44 UTC
Tested with beagle-0.3.9, tracker-0.6.95 and tracker-0.7.3
Comment 5 Cosimo Cecchi 2010-02-20 13:33:16 UTC
Review of attachment 145952 [details] [review]:

The patch itself looks good to me.
Honestly, in the long run, I don't think it's worth to support more than one indexing engine though, and if I had to choose, I'd choose tracker, as it's now an approved external dependency, is well-maintained and has a lot of new and interesting features; this can be a nice solution in the meanwhile anyway. Could you please update the patch moving tracker to be the first option among the engines?
Also, before we commit this, you should assure that your patch takes into account bug #608976. Probably those functions can be easily replaced with something else.
Comment 6 Tomas Bzatek 2010-03-05 17:17:52 UTC
Created attachment 155333 [details] [review]
nautilus-2.28.1-dynamic-search.patch

Updated patch with new tracker API support, tested with 0.6.96 and 0.7.23. Everything is done dynamically, creating nice mess in the source file.

Also, tracker is now preferred search engine.
Comment 7 Cosimo Cecchi 2010-03-05 18:13:50 UTC
Tomas, thanks for the follow-up.
Why did you mark the new patch as 'needs-work'?
Comment 8 Tomas Bzatek 2010-03-08 11:07:17 UTC
Committed to master per discussion on irc.

commit e1e1fe0d505bdb9b53d7204bba0abeee52f73bca
Author: Tomas Bzatek <tbzatek@redhat.com>
Date:   Mon Mar 8 12:01:49 2010 +0100

    Load tracker/beagle at runtime
    
    Dynamically load tracker (preferred) and beagle client libraries on demand if available.
    This allows more flexibility for packagers and users.
    
    See bug 589345 for details.