After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 589045 - Remove deprecated libgnome(ui) dependency
Remove deprecated libgnome(ui) dependency
Status: RESOLVED FIXED
Product: planner
Classification: Other
Component: General
0.14.x
Other Linux
: Normal normal
: ---
Assigned To: planner-maint
planner-maint
cleanup
Depends on: 349304 584009
Blocks: 575129 695210
 
 
Reported: 2009-07-19 19:37 UTC by André Klapper
Modified: 2013-03-05 17:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove deprecated GnomeEntry. (5.92 KB, patch)
2013-03-04 17:16 UTC, Luis Menina
committed Details | Review
Remove deprecated libgnomeui. (3.28 KB, patch)
2013-03-04 17:16 UTC, Luis Menina
committed Details | Review

Description André Klapper 2009-07-19 19:37:22 UTC
http://live.gnome.org/LibgnomeMustDie

libgnome and libgnomeui will be removed for GNOME 3 in a few months.

Work left to do after fixing bug 584009 and bug 349304 that both have patches:

./src/planner-sql-plugin.c:#include <libgnomeui/gnome-entry.h>
./src/planner-main.c:#include <libgnome/gnome-program.h>
./src/planner-main.c:#include <libgnomeui/gnome-ui-init.h>
./eds-backend/utils/create-planner-source.c:#include <libgnome/gnome-init.h>
./eds-backend/planner-source/planner-source.c:#include <libgnome/gnome-i18n.h>
./eds-backend/e-cal-backend-planner.c:#include <libgnome/gnome-i18n.h>
Comment 1 André Klapper 2009-08-08 11:05:51 UTC
The last two ones should be a simple
-#include <libgnome/gnome-i18n.h>
+#include <glib/gi18n.h>

Okay to commit?
Comment 2 André Klapper 2009-11-07 23:12:37 UTC
ping?
Comment 3 Javier Jardón (IRC: jjardon) 2010-03-21 20:33:42 UTC
Hello, Could any planner developer review this?
Comment 4 Javier Jardón (IRC: jjardon) 2010-03-21 23:22:24 UTC
Come fixes committed:

8b9104f145b722dc427ea6f1216e305ad16a64e3 Use gtk_init_with_args() instead GnomeProgram
cae485d1d4dcc14544dd3cf664dbb29e63e91e40 Use gtk_show_uri instead of gnome_help_display and gnome_url_show
ce9da9b7ed30ec19508c3be5e8b38e1fa438eef2 Use gtk_init() instead gnome_program_init()
c982ae3c1ac13b6fdb672d0d3140e8477d18305d Remove unneded libgnome/gnome-i18n.h includes

So the only remaining include is:

./src/planner-sql-plugin.c:#include <libgnomeui/gnome-entry.h>

that should be fixed here or with the bug to port to GtkBuilder from libglade ( bug #589700 )
Comment 5 Luis Menina 2013-03-04 17:16:33 UTC
Created attachment 238019 [details] [review]
Remove deprecated GnomeEntry.

It is replaced by GtkEntry. This means we lose the history
functionality, but that could be reimplemented using GtkComboBoxText
with an entry.
Comment 6 Luis Menina 2013-03-04 17:16:37 UTC
Created attachment 238020 [details] [review]
Remove deprecated libgnomeui.
Comment 7 Alexandre Franke 2013-03-05 13:30:23 UTC
Review of attachment 238019 [details] [review]:

Please push this.
Comment 8 Alexandre Franke 2013-03-05 13:34:55 UTC
Review of attachment 238020 [details] [review]:

This as well.
Comment 9 Luis Menina 2013-03-05 14:44:13 UTC
Pushed.

commit fd8da8994f7006b9fcefc90d2fe5c2b484c7871e
Author: Luis Menina <liberforce@freeside.fr>
Date:   Mon Mar 4 14:42:22 2013 +0100

    Remove deprecated libgnomeui.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=589045

commit cd2b658e83d47e8f49d1bbaf54be6433a21d3758
Author: Luis Menina <liberforce@freeside.fr>
Date:   Mon Mar 4 18:10:26 2013 +0100

    Remove deprecated GnomeEntry.
    
    It is replaced by GtkEntry. This means we lose the history
    functionality, but that could be reimplemented using GtkComboBoxText
    with an entry.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=589045