After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 587756 - MSC playlist_path inconsistantly based on audio_folders location
MSC playlist_path inconsistantly based on audio_folders location
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Device - USB Mass Storage
git master
Other Linux
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Gabriel Burt
: 612342 635350 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-07-04 16:16 UTC by William Witt
Modified: 2012-05-05 18:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
MSC Playlist Path Modification (2.10 KB, patch)
2009-07-04 18:37 UTC, William Witt
needs-work Details | Review
Save playlists relative to BaseDirectory (=mount point) (1.91 KB, patch)
2012-04-08 19:19 UTC, Pavol Babinčák
committed Details | Review

Description William Witt 2009-07-04 16:16:38 UTC
given the following .is_audio_player file on the device:

audio_folders=MUSIC/
folder_depth=0
output_formats=audio/x-ms-wma,audio/mpeg
playlist_format=audio/x-mpegurl,audio/m3u,audio/mpeg-url
playlist_path=MUSIC/

banshee creates playlists in the MUSIC/MUSIC/ directory, but songs are referenced as if the playlist were located in the MUSIC/ directory.

Given this .is_audio_player file on the device:
audio_folders=MUSIC/
folder_depth=0
output_formats=audio/x-ms-wma,audio/mpeg
playlist_format=audio/x-mpegurl,audio/m3u,audio/mpeg-url
playlist_path=.

banshee creates playlists in the MUSIC/ directory, but songs are referenced as if the playlist were located in the root directory of the device.

This discrepancy causes the player (a Sansa Fuze in this case) to be unable use the playlists.

"Exporting" playlists to the device works as designed, but reconnection of the device clears the playlist.
Comment 1 William Witt 2009-07-04 16:18:22 UTC
I am willing to test patches, or attempt to fix with a push in the right direction as to where to start.
Comment 2 William Witt 2009-07-04 18:37:44 UTC
Created attachment 137841 [details] [review]
MSC Playlist Path Modification

Set playlists_path relative to device base directory instead of music directory.

Sets playlist import/export based on playlists_path instead of base directory
Comment 3 Gabriel Burt 2009-08-12 21:14:11 UTC
With this patch, playlists get put on my Android phone in /media/disk/Playlists/ instead of /media/disk/Music/Playlists/ - but the phone sees them, so that's ok.  what's not ok is that the entries in .m3u are like this:

#EXTINF:270,Ben Folds - Time
/media/disk/Music/Ben Folds/Songs For Silverman/10. Time.mp3
#EXTINF:211,Bloc Party - Hunting For Witches [Album Version]
/media/disk/amazonmp3/Bloc_Party/A_Weekend_In_The_City/02_-_Hunting_For_Witches_[Album_Version].mp3

Which somehow the phone is actually smart enough to be ok with, but Banshee (when I eject the device and then plug it back in) only recognized the Ben Folds songs in (not the amazonmp3/ files).
Comment 4 Gabriel Burt 2009-10-27 20:17:17 UTC
Bulk changing the assignee to banshee-maint@gnome.bugs to make it easier for people to get updated on all banshee bugs by following that address.  It's usually quite apparent who is working on a given bug by the comments and/or patches attached.
Comment 5 Jeroen Budts 2010-04-02 22:40:57 UTC
i have noted the same behavior while i was studying the related code to sync playlists. i will try to come up with a fix for this bug while i fix those concerning syncing playlists and relative paths in those playlists
Comment 6 Jeroen Budts 2010-04-09 22:42:51 UTC
I have uploaded a patch which fixes the relative paths to the songs in the playlists. Please see this bug: https://bugzilla.gnome.org/show_bug.cgi?id=560711
Comment 7 Pavol Babinčák 2012-04-08 19:19:45 UTC
Created attachment 211598 [details] [review]
Save playlists relative to BaseDirectory (=mount point)

Updated version of William Witt's patch. This one doesn't suffer by relative path problems described in comment 3. It was fixed resolved with bug 560711.
Comment 8 Bertrand Lorentz 2012-05-05 17:21:31 UTC
Comment on attachment 211598 [details] [review]
Save playlists relative to BaseDirectory (=mount point)

Thanks for the patch, I've committed it with a few additions to update the playlist paths for custom device implementations: Android, RockBox, etc.
Comment 9 Bertrand Lorentz 2012-05-05 17:21:53 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 10 Bertrand Lorentz 2012-05-05 18:15:23 UTC
*** Bug 635350 has been marked as a duplicate of this bug. ***
Comment 11 Bertrand Lorentz 2012-05-05 18:19:25 UTC
*** Bug 612342 has been marked as a duplicate of this bug. ***