GNOME Bugzilla – Bug 585377
Don't require volume-control deps if not building volume-control
Last modified: 2009-06-14 12:32:49 UTC
On OS X 10.4, I don't have pulseaudio, so building the volume-control is disabled in gnome-media-2.26.0. However, I'm still required to install libunique, which is only used as a dependency of the volume-control item. That's annoying...configure should not have a mandatory test for something that will not be used based on another configure test. Solution is in the "Check for the new volume control modules" section of configure.ac: move the PKG_CHECK_MODULES(VOLUME_CONTROL, block a bit later where it can be controlled by --enable-pulseaudio and the other PA dep checks. While fixing there, may as well defer PKG_CHECK_MODULES(PULSEAUDIO, until after knowing that --disable-pulseaudio is not used.
Created attachment 136301 [details] [review] Defer pkg-config until known to be needed This fixes the functional problem. The philosophical/time-wasting problem of testing for PA deps even if --disable-pulseaudio remains.
makes sense. please apply
commit 83ab62f651c9500d723bfc45b38f869793df3355 Author: Marc-André Lureau <marcandre.lureau@gmail.com> Date: Sun Jun 14 15:21:32 2009 +0300 Bug 585377 – Don't require volume-control deps if not building volume-control Based on patch by Daniel Macks