GNOME Bugzilla – Bug 585343
[PATCH] gimp-gap-2.6.0 warnings and portability error fixes
Last modified: 2009-06-20 08:25:08 UTC
Attached patch fixes many serious compiler warnings and portability issues: - Implicit declarations. Some of them cause miscompilation on x86_64 nearly for sure. - Use of functions that were intended to be local and were not declared in headers. - Errors in DESTDIR installation. - Use of disabled deprecated functions of libgimp. - Use of uninitialized variable. - Incorrect number of arguments in printf - Syntax error in gap_gve_png.h. - Writing to array out of subscript range. Note that ffmpeg copy bundled with gimp-gap-2.6.0 also contains several errors of this type not covered by the attached patch: libavcodec/4xm.c:485 libavcodec/dca.c:1010 libavutil/aes.c:133, 187 libavutil/lls.c:87 This patch does not include an other cosmetic fix: Use of #include "" for external includes (glib, gtk, libgimp). It's also recommended to do a locale rename: sed -i -e "s,sr@Latn,sr@latin," po/LINGUAS mv po/sr@Latn.po po/sr@latin.po
Created attachment 136274 [details] [review] gimp-gap-warnings.patch
*** Bug 585342 has been marked as a duplicate of this bug. ***
Created attachment 136280 [details] [review] gimp-gap-warnings2.patch Additional fix of random behavior. It seems, that one of the functions was intended to be void, in the second case the return value is used but never set.
Thanks for providing fixes for gimp-gap warnings and bugs. After review and testing i applied the changes to the master git repository with one exception: instead of enable usaage of deprecated gimp procedures the dprecated gimp_md5_get_digest procedure was replaced as suggested by the GIMP implementation. note that ffmpeg is included in the gimp-gap repository just for convenient build purpose, but is not maintained here. See http://www.ffmpeg.org/bugreports.html for reporting bugs related to the ffmpeg code. (fixes will require porting gimp-gap to a new ffmpeg release but this may only happen in case of errors that break important features)