After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 584700 - TIFF pixbuf loader should support compression
TIFF pixbuf loader should support compression
Status: RESOLVED FIXED
Product: gdk-pixbuf
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2009-06-03 10:52 UTC by Christian Dywan
Modified: 2010-07-10 04:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Test reading and writing compression (902 bytes, patch)
2009-06-03 11:20 UTC, Christian Dywan
none Details | Review
Implement reading and writing "compression" option (2.18 KB, patch)
2009-06-03 11:38 UTC, Christian Dywan
needs-work Details | Review
Implement "compression", with documentation (2.89 KB, patch)
2009-06-10 15:10 UTC, Christian Dywan
accepted-commit_now Details | Review

Description Christian Dywan 2009-06-03 10:52:27 UTC
The TIFF pixbuf loader currently always dumps the image data to the disk. It should support using a selected manner of compression (codec) as an 'option'.
Comment 1 Christian Dywan 2009-06-03 11:20:02 UTC
Created attachment 135869 [details] [review]
Test reading and writing compression
Comment 2 Christian Dywan 2009-06-03 11:38:56 UTC
Created attachment 135870 [details] [review]
Implement reading and writing "compression" option

This change implements a "compression" option when loading or saving TIFF that is based on the TIFF compression tag.
Comment 3 Matthias Clasen 2009-06-05 23:40:19 UTC
I don't really see the point in exposing the compression option on loaded images.
Other than that, looks reasonable. 

The 'compression' parameter should be mentioned in the relevant doc comments in gdk-pixbuf-io.c
Comment 4 Christian Dywan 2009-06-10 15:10:46 UTC
Created attachment 136275 [details] [review]
Implement "compression", with documentation

I added documentation to gdk_pixbuf_save.

I find it very useful to read the compression because for a concrete example, monochromatic images can be compressed with codec 3, FAX encoding, which doesn't work with coloured images. So if I want to load, and later save such a file I want to be able to re-encode it with its original codec.
Comment 5 Tim Janik 2009-06-30 08:44:31 UTC
(In reply to comment #3)
> I don't really see the point in exposing the compression option on loaded
> images.

Well, I do. GdkPixbuf should allow an application to preserve the compression format when loading and saving an image file. For this, the app needs to be able to read-out if an image was compressed in the first place and how.
Comment 6 Matthias Clasen 2009-11-27 23:53:13 UTC
Comment on attachment 136275 [details] [review]
Implement "compression", with documentation

Looks good to commit.
Comment 7 Christian Dywan 2009-11-30 12:59:04 UTC
Pushed to master.