After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 584235 - [mpegtsparse] Add timestamp capability to mpegtsparse
[mpegtsparse] Add timestamp capability to mpegtsparse
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-05-29 20:32 UTC by Vitaly Bordug
Modified: 2011-05-20 07:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tentative patch to address the problem (14.96 KB, patch)
2009-05-29 20:36 UTC, Vitaly Bordug 		needs-work Details | Review

Description Vitaly Bordug 2009-05-29 20:32:54 UTC 
Currenty mpegtsparse does is not aware of timestamps, which makes extremely hard plain stupid streaming of mpeg-ts data. Moreover, in order to stream it, we used to have to use at meast demux+mux, or even decodebin to fill in all the timestamps in gaps.

Without patch, gstreamer just sends stuff as fast as possible, making whole thing on rtp an oxymoron.
Comment 1 Vitaly Bordug 2009-05-29 20:36:19 UTC 
Created attachment 135581 [details] [review]
tentative patch to address the problem

This is partially what decodebin does to provide proper timestamps, while decoding and demuxing.
Comment 2 Wim Taymans 2009-06-01 15:31:01 UTC 
+
+	GST_TIME_TO_TIMESPEC(
+		GST_TIMESPEC_TO_TIME(init_ts) + pts * 10000L, current_ts);
+
+	clock_nanosleep(CLOCK_REALTIME, TIMER_ABSTIME, &current_ts, NULL);
+}
+

It's not allowed to sleep in elements like this. Also I don't see why one should sleep there just to put timestamps on buffers.
Comment 3 Vitaly Bordug 2009-06-02 20:45:08 UTC 
it is a debug hunk that missed cleanup - I'll rip it out. Anything else to take into account?
Comment 4 Sebastian Dröge (slomo) 2011-05-20 06:35:25 UTC 
What's the progress of this bug? There seems to be timestamp support now
Comment 5 Vitaly Bordug 2011-05-20 06:43:37 UTC 
well at that point we had to switch to libvlc for that particular streams to address the problem.

If there is such a thing in mainline already, I'll close this bug. But can't really test it since the setup doesn't exist anymore...
Comment 6 Sebastian Dröge (slomo) 2011-05-20 07:49:28 UTC 
Ok, then let's close this for now.