After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 584217 - [housekeeping] low-disk space warning doesn't work due to missing #include
[housekeeping] low-disk space warning doesn't work due to missing #include
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: plugins
2.27.x
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2009-05-29 16:52 UTC by Chris Coulson
Modified: 2009-06-01 13:48 UTC
See Also:
GNOME target: ---
GNOME version: 2.27/2.28



Description Chris Coulson 2009-05-29 16:52:07 UTC
Please describe the problem:
While doing some work with this plugin in Ubuntu, I noticed that the ldsm code does not get compiled in because "#ifdef HAVE_LIBNOTIFY" evaluates to FALSE in plugins/housekeeping/gsd-disk-space.c, even though I have libnotify-dev installed. This is because gsd-disk-space.c misses an `#include "<config.h>"`.

Adding the extra #include here makes the code compile in and work correctly.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Jens Granseuer 2009-06-01 13:48:24 UTC
Thanks!

2009-06-01  Jens Granseuer  <...>

        * plugins/housekeeping/gsd-disk-space.c: include config.h so the
        notifications stuff can actually be built (bug #584217)