After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 582373 - can't authenticate to webdav share
can't authenticate to webdav share
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: webdav backend
git master
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2009-05-12 17:14 UTC by Frederic Peters
Modified: 2009-05-26 10:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
reuse known username if a new one is not set (444 bytes, patch)
2009-05-12 17:17 UTC, Frederic Peters 		committed Details | Review

Description Frederic Peters 2009-05-12 17:14:48 UTC 
Failing to authenticate to a webdav server (Apache) with gvfsd running in foreground I got this message from libsoup:

(process:22387): libsoup-CRITICAL **: soup_auth_authenticate: assertion `username != NULL' failed

It happens in soup_authenticate_interactive, after g_mount_source_ask_password is called to ask for a password.  The problem is new_username, which is expected to be filled by that function, is not, and the next call fails:

  soup_auth_authenticate (auth, new_username, new_password);
Comment 1 Frederic Peters 2009-05-12 17:17:48 UTC 
Created attachment 134514 [details] [review]
reuse known username if a new one is not set

I don't know if it is caused by a wrong assumption about the semantics of g_mount_source_ask_password, or an error there.

This patch considers g_mount_source_ask_password to be okay and fixes the issue by updating gvfsbackenddav.c, to use the previously known username if new_username is not filled by g_mount_source_ask_password.
Comment 2 Christian Kellner 2009-05-26 10:27:20 UTC 
Hey Frederic, I guess you are right. I committed the patch to master. Thanks a bunch.