After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 581917 - Please show icons for devices
Please show icons for devices
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Sound
unspecified
Other All
: Normal enhancement
: ---
Assigned To: gnome media maintainers
gnome media maintainers
: 599109 (view as bug list)
Depends on: 598261
Blocks:
 
 
Reported: 2009-05-08 18:26 UTC by Lennart Poettering
Modified: 2010-12-09 12:47 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
gvc-add-device-icons.patch (7.87 KB, patch)
2009-05-09 01:29 UTC, Bastien Nocera
needs-work Details | Review
showing the icons (23.17 KB, image/png)
2009-05-09 19:09 UTC, Bastien Nocera
  Details
audio-headset icons by Hylke Bons and Andreas Nilsson (just some tweaks from me) (22.06 KB, application/x-gzip)
2009-08-01 13:07 UTC, Andreas Nilsson
  Details
Bug 581917 - Please show icons for devices (11.99 KB, patch)
2009-10-13 12:36 UTC, Bastien Nocera
committed Details | Review
Audio preferences with plugged USB speakers (41.27 KB, image/png)
2010-01-20 13:44 UTC, Luca Ferretti
  Details

Description Lennart Poettering 2009-05-08 18:26:06 UTC
PA sets PA_PROP_DEVICE_ICON for almost all sinks/sources now. It's an XDG icon name matching the 'form factor' and connector of the hw. I think it would make a lot of sense to make use of it in the UI to allow distuingishing sound cards more easily. i.e. show a camera icon for the web cam sound source, a TV icon for the TV card, and so on.

When Rodney gets off his ass we'll hopefully also be able to provide different icons for headphones and external speakers and so on. 

Given that most device description strings are not exactly useful right now the icon could probably help users to identify their hardware more easily.
Comment 1 Bastien Nocera 2009-05-09 01:29:08 UTC
Created attachment 134293 [details] [review]
gvc-add-device-icons.patch

I guess you meant PA_PROP_DEVICE_ICON_NAME, PA_PROP_DEVICE_ICON seems to be empty for what I tried.

Looks very very arse right now.
Comment 2 Lennart Poettering 2009-05-09 01:58:00 UTC
Hmm, when I apply that patch I don't see any icon.

Hmm, the icon names PA sets need to be resolved with the fallback icon name logic enabled. I don't think the icon cell renderer does that by default.

You might need to load those icons manually via gtk_icon_theme_load_icon(..., GTK_ICON_LOOKUP_GENERIC_FALLBACK).

That's at least what I had to do in pavucontrol.
Comment 3 Bastien Nocera 2009-05-09 19:09:08 UTC
Created attachment 134317 [details]
showing the icons

That shows the PNG images.
Comment 4 Bastien Nocera 2009-05-09 19:10:44 UTC
Which all seem to be fallback ones... The cell renderer should probably be fixed to do fallback, as we don't have much control over the contents of the pixbuf itself.
Comment 5 Lennart Poettering 2009-05-12 21:56:07 UTC
BTW, I have now put up a request for more expressive icons for the form factors:

http://live.gnome.org/GnomeArt/ArtRequests/GenericAudioIcons
Comment 6 Bastien Nocera 2009-05-13 16:30:37 UTC
Will need to:
- wait for the icons to be made and useful
- use a function to set the icon name, so we can do fallback ourselves
- change the applet's tooltip to be <big>level</big>\nstuff (and not level\n<small>stuff</small>)
- add an device icon to the tooltip
Comment 7 Andreas Nilsson 2009-08-01 13:07:51 UTC
Created attachment 139686 [details]
audio-headset icons by Hylke Bons and Andreas Nilsson (just some tweaks from me)
Comment 8 Bastien Nocera 2009-10-13 12:36:00 UTC
Created attachment 145346 [details] [review]
Bug 581917 - Please show icons for devices

Show device icons in the stream treeviews. Use GIcon
to get automatic fallback.
Comment 9 Marc-Andre Lureau 2010-01-11 23:45:39 UTC
let's try to get that in for 2.29.6, in 2 weeks from now, I'll catch you on irc.
Comment 10 Luca Ferretti 2010-01-20 13:44:02 UTC
Created attachment 151835 [details]
Audio preferences with plugged USB speakers

I've recently bought new USB speakers. The missing icon in attached screenshot (2.28) is due to this bug, isn't it?

PS do you need any check/test/debug for this hardware?
Comment 11 Bastien Nocera 2010-11-10 13:16:01 UTC
Mass move to gnome-control-center.
Comment 12 Bastien Nocera 2010-11-19 16:21:02 UTC
(In reply to comment #10)
> Created an attachment (id=151835) [details]
> Audio preferences with plugged USB speakers
> 
> I've recently bought new USB speakers. The missing icon in attached screenshot
> (2.28) is due to this bug, isn't it?
> 
> PS do you need any check/test/debug for this hardware?

Probably not related, file a separate bug with the output of "pacmd list-cards"
Comment 13 Bastien Nocera 2010-11-19 16:25:35 UTC
And committed the icons as well, though they might need a little updating for the new style.
Comment 14 Bastien Nocera 2010-12-09 12:47:01 UTC
*** Bug 599109 has been marked as a duplicate of this bug. ***