After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 581180 - Set as background on Right click
Set as background on Right click
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
2.26.x
Other All
: Normal enhancement
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-05-03 13:19 UTC by Cyriac Thomas
Modified: 2009-05-03 20:52 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26


Attachments
This the complete patch for the bug 581180, tested and working. (1.58 KB, patch)
2009-05-03 13:25 UTC, Cyriac Thomas
none Details | Review

Description Cyriac Thomas 2009-05-03 13:19:32 UTC
Most image viewers provide facility for set as desktop background on clicking on the image. A facility for eog like that would improve usabilty. Also a shortcut like "F8" would be good.

Other information:
Comment 1 Cyriac Thomas 2009-05-03 13:25:00 UTC
Created attachment 133860 [details] [review]
This the complete patch for the  bug 581180, tested and working.

files edited are src/eog-window.c, data/eog-window.c, ChangeLog
Comment 2 Cyriac Thomas 2009-05-03 13:52:42 UTC
Comment on attachment 133860 [details] [review]
This the complete patch for the  bug 581180, tested and working.

>--- src/eog-window.c	2009-04-14 00:19:40.000000000 +0530
>+++ src/eog-window.c	2009-05-03 18:20:05.000000000 +0530
>@@ -3473,7 +3473,7 @@
> 	{ "EditRotate270", "object-rotate-left", N_("Rotate Counterc_lockwise"), "<ctrl><shift>r",
> 	  N_("Rotate the image 90 degrees to the left"),
> 	  G_CALLBACK (eog_window_cmd_rotate_270) },
>-	{ "SetAsWallpaper", NULL, N_("Set as _Desktop Background"), NULL,
>+	{ "SetAsWallpaper", NULL, N_("Set as _Desktop Background"), "F8",
> 	  N_("Set the selected image as the desktop background"),
> 	  G_CALLBACK (eog_window_cmd_wallpaper) },
> 	{ "EditMoveToTrash", "user-trash", N_("Move to _Trash"), NULL,
>--- data/eog-ui.xml	2009-04-14 00:19:41.000000000 +0530
>+++ data/eog-ui.xml	2009-05-03 18:18:47.000000000 +0530
>@@ -114,6 +114,7 @@
>     <menuitem action="EditMoveToTrash"/>
>     <separator/>
>     <menuitem action="FileProperties"/>
>+    <menuitem action="SetAsWallpaper"/>
>   </popup>
> 
>   <popup name="ViewPopup">
>@@ -129,6 +130,7 @@
>     <menuitem action="EditMoveToTrash"/>
>     <separator/>
>     <menuitem action="FileProperties"/>
>+    <menuitem action="SetAsWallpaper"/>
>   </popup>
> 
>   <accelerator name="ControlEqualAccel" action="ControlEqual"/>
>--- ChangeLog	2009-04-14 00:58:40.000000000 +0530
>+++ ChangeLog	2009-05-03 18:26:53.000000000 +0530
>@@ -1,3 +1,11 @@
>+2009-04-30  Cyriac Thomas  <cyriacsmail@gmail.com>
>+
>+	* src/eog-window.c:
>+	* data/eog-ui.xml:
>+	Added Set as Desktop background on the right click menu for the
>+	main image and image collection. Also added a Keyboard shortcut
>+	"F8" for the same.
>+
> 2009-04-13  Felix Riemann  <friemann@svn.gnome.org>
> 
> 	* NEWS: Update for 2.26.1
Comment 3 Felix Riemann 2009-05-03 19:26:24 UTC
Nice idea, thanks. I changed the shortcut to Ctrl+F8 though, because plain F8 might be needed for navigation (see http://library.gnome.org/devel/hig-book/stable/input-keyboard.html.en#standard-shortcuts).

commit d6a21b8f3adcb5a38f889cd419514835e3ff8226
Author: Cyriac Thomas <>
Date:   Sun May 3 21:15:32 2009 +0200

    Bug 581180 – Set as background on Right click
    
    Added Set as Desktop background on the right click menu for the
    main image and image collection. Also added a Keyboard shortcut
    "Ctrl+F8" for the same. Fixes bug #581180.

 3 files changed, 12 insertions(+), 2 deletions(-)
---------------------------------------------------------------------------------
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 4 Cyriac Thomas 2009-05-03 20:52:09 UTC
Thanks for the info about standard shortcuts. You are the boss :)